Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: runtime/vm/isolate.cc

Issue 211283004: Support Types in instance-ref/instance-view (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 673fa0b72f1f76797b4c546e470f302248403245..185aa9c8c733c3d9955e9121a019c90d632891a6 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -897,6 +897,8 @@ void Isolate::PrintToJSONStream(JSONStream* stream, bool ref) {
jsheap.AddProperty("capacityOld", heap()->CapacityInWords(Heap::kOld));
}
+ // TODO(turnidge): Don't compute a full stack trace every time we
+ // request an isolate's info.
DebuggerStackTrace* stack = debugger()->StackTrace();
if (stack->Length() > 0) {
JSONObject jsframe(&jsobj, "topFrame");

Powered by Google App Engine
This is Rietveld 408576698