Support Types in instance-ref/instance-view

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "lib/mirrors.h"
@@ skipping 881 matching lines @@
     }
   }
   {
     JSONObject jsheap(&jsobj, "heap");
     jsheap.AddProperty("usedNew", heap()->UsedInWords(Heap::kNew));
     jsheap.AddProperty("capacityNew", heap()->CapacityInWords(Heap::kNew));
     jsheap.AddProperty("usedOld", heap()->UsedInWords(Heap::kOld));
     jsheap.AddProperty("capacityOld", heap()->CapacityInWords(Heap::kOld));
   }
 
+  // TODO(turnidge): Don't compute a full stack trace every time we
+  // request an isolate's info.
   DebuggerStackTrace* stack = debugger()->StackTrace();
   if (stack->Length() > 0) {
     JSONObject jsframe(&jsobj, "topFrame");
 
     ActivationFrame* frame = stack->FrameAt(0);
     frame->PrintToJSONObject(&jsobj);
     // TODO(turnidge): Implement depth differently -- differentiate
     // inlined frames.
     jsobj.AddProperty("depth", (intptr_t)0);
   }
@@ skipping 207 matching lines @@
   return func.raw();
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(isolate());
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart