Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2112803002: MD History: Trim long item titles to reduce effect on performance (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Trim long item titles to reduce effect on performance History items with extremely long titles are very slow to render, due to needing to layout the entire title in order to determine where to cut it off with ellipses. This greatly degrades the performance of MD History in a profile which has visited several of these items. This CL trims titles down to at most 300 characters before they are rendered, which has no visible effect, but greatly improves performance. On a profile that has visited crashsafari[dot]com, load time is reduced from ~5000ms to ~1800ms on my Z620. Scrolling performance is also greatly improved. BUG=621347 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/24e3e3772122abf6a01683c9b412256228428fd7 Cr-Commit-Position: refs/heads/master@{#403351}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/browser/resources/md_history/constants.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tsergeant
4 years, 5 months ago (2016-06-30 06:25:32 UTC) #3
Dan Beam
lgtm
4 years, 5 months ago (2016-06-30 23:31:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112803002/20001
4 years, 5 months ago (2016-06-30 23:41:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 23:54:04 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:54:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:57:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24e3e3772122abf6a01683c9b412256228428fd7
Cr-Commit-Position: refs/heads/master@{#403351}

Powered by Google App Engine
This is Rietveld 408576698