third_party/WebKit/LayoutTests/paint/subpixel/subpixel-accumulation-with-fixedpos.html - Issue 2112753002: Snap paint offset paint property to pixel boundaries

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/subpixel/subpixel-accumulation-with-fixedpos.html

Issue 2112753002: Snap paint offset paint property to pixel boundaries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add more tests, cleanup comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/paint/subpixel/subpixel-accumulation-with-fixedpos-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 PASS if there is no red visible.

	3 <div style="background: white; width: 100px; height: 100px; position: relative; left: 0.7px;">
	chrishtr 2016/06/30 16:57:17 Unittest with fixed-pos also? Unittest with fixed-pos also? pdr. 2016/06/30 18:54:48 Added PaintPropertyTreeBuilderTest.PaintOffsetWith Show quoted text On 2016/06/30 at 16:57:17, chrishtr wrote: > Unittest with fixed-pos also? Added PaintPropertyTreeBuilderTest.PaintOffsetWithPixelSnappingWithFixedPos
	4 <div style="background: white; width: 70px; height: 70px; position: relative ; transform: translateZ(0);">

	5 <div style="background: red; width: 40px; height: 40px; position: fixed; ">

	6 <!-- Because the first div is snapped up to (1,1), this div will sta rt with a -->

	7 <!-- paint offset of (-0.3,-0.3) which will be added to (0.7,0.7) to get -->

	8 <!-- (0.4,0.4) which rounds down to (0,0) and obscures the red divs. -->

	9 <div style="width: 40px; height: 40px; background: white; position: relative; left: 0.7px;"></div>

	10 </div>

	11 </div>

	12 </div>

OLD	NEW