Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2112733003: [turbofan] Allow OptionalOperator to return a placeholder. (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow OptionalOperator to return a placeholder. R=bmeurer@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/fa69cbb86b6f91063cf0c5ebc6bc6534be237849 Cr-Commit-Position: refs/heads/master@{#37445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M src/compiler/machine-operator.h View 3 chunks +9 lines, -5 lines 0 comments Download
M src/compiler/machine-operator.cc View 2 chunks +4 lines, -18 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 5 months ago (2016-06-30 13:45:06 UTC) #1
ahaas
lgtm, I like it!
4 years, 5 months ago (2016-06-30 13:49:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112733003/1
4 years, 5 months ago (2016-06-30 13:54:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 14:16:52 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:18:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa69cbb86b6f91063cf0c5ebc6bc6534be237849
Cr-Commit-Position: refs/heads/master@{#37445}

Powered by Google App Engine
This is Rietveld 408576698