Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/hydrogen-instructions.h

Issue 211273010: Fix missing representation for the result of HIsSmiAndBranch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-is-smi-repr.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4385 matching lines...) Expand 10 before | Expand all | Expand 10 after
4396 } 4396 }
4397 4397
4398 protected: 4398 protected:
4399 virtual bool DataEquals(HValue* other) V8_OVERRIDE { return true; } 4399 virtual bool DataEquals(HValue* other) V8_OVERRIDE { return true; }
4400 virtual int RedefinedOperandIndex() { return 0; } 4400 virtual int RedefinedOperandIndex() { return 0; }
4401 4401
4402 private: 4402 private:
4403 HIsSmiAndBranch(HValue* value, 4403 HIsSmiAndBranch(HValue* value,
4404 HBasicBlock* true_target = NULL, 4404 HBasicBlock* true_target = NULL,
4405 HBasicBlock* false_target = NULL) 4405 HBasicBlock* false_target = NULL)
4406 : HUnaryControlInstruction(value, true_target, false_target) {} 4406 : HUnaryControlInstruction(value, true_target, false_target) {
4407 set_representation(Representation::Tagged());
4408 }
4407 }; 4409 };
4408 4410
4409 4411
4410 class HIsUndetectableAndBranch V8_FINAL : public HUnaryControlInstruction { 4412 class HIsUndetectableAndBranch V8_FINAL : public HUnaryControlInstruction {
4411 public: 4413 public:
4412 DECLARE_INSTRUCTION_FACTORY_P1(HIsUndetectableAndBranch, HValue*); 4414 DECLARE_INSTRUCTION_FACTORY_P1(HIsUndetectableAndBranch, HValue*);
4413 DECLARE_INSTRUCTION_FACTORY_P3(HIsUndetectableAndBranch, HValue*, 4415 DECLARE_INSTRUCTION_FACTORY_P3(HIsUndetectableAndBranch, HValue*,
4414 HBasicBlock*, HBasicBlock*); 4416 HBasicBlock*, HBasicBlock*);
4415 4417
4416 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE { 4418 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
(...skipping 3102 matching lines...) Expand 10 before | Expand all | Expand 10 after
7519 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7521 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7520 }; 7522 };
7521 7523
7522 7524
7523 #undef DECLARE_INSTRUCTION 7525 #undef DECLARE_INSTRUCTION
7524 #undef DECLARE_CONCRETE_INSTRUCTION 7526 #undef DECLARE_CONCRETE_INSTRUCTION
7525 7527
7526 } } // namespace v8::internal 7528 } } // namespace v8::internal
7527 7529
7528 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7530 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-is-smi-repr.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698