Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1797)

Unified Diff: Source/devtools/front_end/HeapSnapshotProxy.js

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshotProxy.js
diff --git a/Source/devtools/front_end/HeapSnapshotProxy.js b/Source/devtools/front_end/HeapSnapshotProxy.js
index 660ddde1a985511014e4d5f2b2926ad79ee236a2..239653a77be77ed1821c25d8002150cd47bc4d54 100644
--- a/Source/devtools/front_end/HeapSnapshotProxy.js
+++ b/Source/devtools/front_end/HeapSnapshotProxy.js
@@ -77,13 +77,6 @@ WebInspector.HeapSnapshotWorkerProxy.prototype = {
this._postMessage({callId: callId, disposition: "evaluateForTest", source: script});
},
- callGetter: function(callback, objectId, getterName)
- {
- var callId = this._nextCallId++;
- this._callbacks[callId] = callback;
- this._postMessage({callId: callId, disposition: "getter", objectId: objectId, methodName: getterName});
- },
-
/**
* @param {?function(...[?])} callback
* @param {string} objectId
@@ -233,17 +226,6 @@ WebInspector.HeapSnapshotProxyObject.prototype = {
/**
* @param {function(T)|undefined} callback
- * @param {string} getterName
- * @return {*}
- * @template T
- */
- callGetter: function(callback, getterName)
- {
- return this._callWorker("callGetter", Array.prototype.slice.call(arguments, 0));
- },
-
- /**
- * @param {function(T)|undefined} callback
* @param {string} methodName
* @param {...*} var_args
* @return {*}
@@ -252,10 +234,6 @@ WebInspector.HeapSnapshotProxyObject.prototype = {
callMethod: function(callback, methodName, var_args)
{
return this._callWorker("callMethod", Array.prototype.slice.call(arguments, 0));
- },
-
- get worker() {
- return this._worker;
}
};
@@ -363,21 +341,21 @@ WebInspector.HeapSnapshotProxy.prototype = {
/**
* @param {number} nodeIndex
* @param {boolean} showHiddenData
- * @return {?WebInspector.HeapSnapshotProviderProxy}
+ * @return {!WebInspector.HeapSnapshotProviderProxy}
*/
createEdgesProvider: function(nodeIndex, showHiddenData)
{
- return this.callFactoryMethod(null, "createEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex, showHiddenData);
+ return /** @type {!WebInspector.HeapSnapshotProviderProxy} */ (this.callFactoryMethod(null, "createEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex, showHiddenData));
},
/**
* @param {number} nodeIndex
* @param {boolean} showHiddenData
- * @return {?WebInspector.HeapSnapshotProviderProxy}
+ * @return {!WebInspector.HeapSnapshotProviderProxy}
*/
createRetainingEdgesProvider: function(nodeIndex, showHiddenData)
{
- return this.callFactoryMethod(null, "createRetainingEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex, showHiddenData);
+ return /** @type {!WebInspector.HeapSnapshotProviderProxy} */ (this.callFactoryMethod(null, "createRetainingEdgesProvider", WebInspector.HeapSnapshotProviderProxy, nodeIndex, showHiddenData));
},
/**

Powered by Google App Engine
This is Rietveld 408576698