Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: Source/devtools/front_end/HeapSnapshotView.js

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotProxy.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 760 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 this._constructorsDataGrid.setAllocationNodeId(selectedNode.allocationNo deId()); 771 this._constructorsDataGrid.setAllocationNodeId(selectedNode.allocationNo deId());
772 }, 772 },
773 773
774 _inspectedObjectChanged: function(event) 774 _inspectedObjectChanged: function(event)
775 { 775 {
776 var selectedNode = event.target.selectedNode; 776 var selectedNode = event.target.selectedNode;
777 if (!this._profile.fromFile() && selectedNode instanceof WebInspector.He apSnapshotGenericObjectNode) 777 if (!this._profile.fromFile() && selectedNode instanceof WebInspector.He apSnapshotGenericObjectNode)
778 ConsoleAgent.addInspectedHeapObject(selectedNode.snapshotNodeId); 778 ConsoleAgent.addInspectedHeapObject(selectedNode.snapshotNodeId);
779 }, 779 },
780 780
781 /**
782 * @param {?WebInspector.HeapSnapshotGridNode} nodeItem
783 */
781 _setRetainmentDataGridSource: function(nodeItem) 784 _setRetainmentDataGridSource: function(nodeItem)
782 { 785 {
783 if (nodeItem && nodeItem.snapshotNodeIndex) 786 var dataSource = nodeItem && nodeItem.retainersDataSource();
784 this._retainmentDataGrid.setDataSource(nodeItem.isDeletedNode ? node Item.dataGrid.baseSnapshot : nodeItem.dataGrid.snapshot, nodeItem.snapshotNodeIn dex); 787 if (dataSource)
788 this._retainmentDataGrid.setDataSource(dataSource.snapshot, dataSour ce.snapshotNodeIndex);
785 else 789 else
786 this._retainmentDataGrid.reset(); 790 this._retainmentDataGrid.reset();
787 }, 791 },
788 792
789 /** 793 /**
790 * @param {string} perspectiveTitle 794 * @param {string} perspectiveTitle
791 * @param {function()} callback 795 * @param {function()} callback
792 */ 796 */
793 _changePerspectiveAndWait: function(perspectiveTitle, callback) 797 _changePerspectiveAndWait: function(perspectiveTitle, callback)
794 { 798 {
(...skipping 1365 matching lines...) Expand 10 before | Expand all | Expand 10 after
2160 if (color) 2164 if (color)
2161 swatchDiv.style.backgroundColor = color; 2165 swatchDiv.style.backgroundColor = color;
2162 else 2166 else
2163 swatchDiv.classList.add("heap-snapshot-stats-empty-swatch"); 2167 swatchDiv.classList.add("heap-snapshot-stats-empty-swatch");
2164 nameDiv.textContent = name; 2168 nameDiv.textContent = name;
2165 sizeDiv.textContent = WebInspector.UIString("%s KB", Number.withThousand sSeparator(Math.round(value / 1024))); 2169 sizeDiv.textContent = WebInspector.UIString("%s KB", Number.withThousand sSeparator(Math.round(value / 1024)));
2166 }, 2170 },
2167 2171
2168 __proto__: WebInspector.VBox.prototype 2172 __proto__: WebInspector.VBox.prototype
2169 } 2173 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotProxy.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698