Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/devtools/front_end/HeapSnapshotDataGrids.js

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 ]; 611 ];
612 WebInspector.HeapSnapshotSortableDataGrid.call(this, columns); 612 WebInspector.HeapSnapshotSortableDataGrid.call(this, columns);
613 } 613 }
614 614
615 WebInspector.HeapSnapshotContainmentDataGrid.prototype = { 615 WebInspector.HeapSnapshotContainmentDataGrid.prototype = {
616 setDataSource: function(snapshot, nodeIndex) 616 setDataSource: function(snapshot, nodeIndex)
617 { 617 {
618 this.snapshot = snapshot; 618 this.snapshot = snapshot;
619 var node = { nodeIndex: nodeIndex || snapshot.rootNodeIndex }; 619 var node = { nodeIndex: nodeIndex || snapshot.rootNodeIndex };
620 var fakeEdge = { node: node }; 620 var fakeEdge = { node: node };
621 this.setRootNode(new WebInspector.HeapSnapshotObjectNode(this, false, fa keEdge, null)); 621 this.setRootNode(new WebInspector.HeapSnapshotObjectNode(this, snapshot, fakeEdge, null));
622 this.rootNode().sort(); 622 this.rootNode().sort();
623 }, 623 },
624 624
625 sortingChanged: function() 625 sortingChanged: function()
626 { 626 {
627 var rootNode = this.rootNode(); 627 var rootNode = this.rootNode();
628 if (rootNode.hasChildren) 628 if (rootNode.hasChildren)
629 rootNode.sort(); 629 rootNode.sort();
630 }, 630 },
631 631
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
1121 return compareResult; 1121 return compareResult;
1122 if (a[fieldName] < b[fieldName]) 1122 if (a[fieldName] < b[fieldName])
1123 return -compareResult; 1123 return -compareResult;
1124 return 0; 1124 return 0;
1125 } 1125 }
1126 return compare; 1126 return compare;
1127 }, 1127 },
1128 1128
1129 __proto__: WebInspector.DataGrid.prototype 1129 __proto__: WebInspector.DataGrid.prototype
1130 } 1130 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/HeapSnapshot.js ('k') | Source/devtools/front_end/HeapSnapshotGridNodes.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698