Do not override data getter in heap snapshot grid nodes

LayoutTests/inspector/profiler/heap-snapshot-test.js

 var initialize_HeapSnapshotTest = function() {
 
 InspectorTest.createHeapSnapshotMockFactories = function() {
 
 InspectorTest.createJSHeapSnapshotMockObject = function()
 {
     return {
         _rootNodeIndex: 0,
         _nodeTypeOffset: 0,
         _nodeNameOffset: 1,
@@ skipping 463 matching lines @@
 };
 
 InspectorTest.checkArrayIsSorted = function(contents, sortType, sortOrder)
 {
     function simpleComparator(a, b)
     {
         return a < b ? -1 : (a > b ? 1 : 0);
     }
     function parseSize(size)
     {
-        if (size.substr(0, 1) === '"') size = JSON.parse(size);
         // Remove thousands separator.
-        return parseInt(size.replace(/[\u2009,]/g, ""));
-    }
-    function extractField(data, field)
-    {
-        if (data.substr(0, 1) !== "{") return data;
-        data = JSON.parse(data);
-        if (!data[field])
-            InspectorTest.addResult("No " + field + " field in " + JSON.stringify(data));
-        return data[field];
-    }
-    function extractId(data)
-    {
-        return parseInt(extractField(data, "nodeId"));
+        return parseInt(size.replace(/[\u2009,]/g, ""), 10);
     }
     var extractor = {
-        text: function (data) { return extractField(data, "value"); },
+        text: function (data) { data; },
         number: function (data) { return parseInt(data, 10); },
-        size: function (data) { return parseSize(data); },
-        name: function (data) { return extractField(data, "name"); },
-        id: function (data) { return extractId(data); }
+        size: parseSize,
+        name: function (data) { return data; },
+        id: function (data) { return parseInt(data, 10); }
     }[sortType];
     var acceptableComparisonResult = {
         ascending: -1,
         descending: 1
     }[sortOrder];
 
     if (!extractor) {
         InspectorTest.addResult("Invalid sort type: " + sortType);
         return;
     }
     if (!acceptableComparisonResult) {
         InspectorTest.addResult("Invalid sort order: " + sortOrder);
         return;
     }
 
     for (var i = 0; i < contents.length - 1; ++i) {
         var a = extractor(contents[i]);
         var b = extractor(contents[i + 1]);
         var result = simpleComparator(a, b);
-        if (result !== 0 && result !== acceptableComparisonResult)
+        if (result !== 0 && result !== acceptableComparisonResult) {
             InspectorTest.addResult("Elements " + i + " and " + (i + 1) + " are out of order: " + a + " " + b + " (" + sortOrder + ")");
+        }
     }
 };
 
 InspectorTest.clickColumn = function(column, callback)
 {
     callback = InspectorTest.safeWrap(callback);
     var cell = this._currentGrid()._headerTableHeaders[column.identifier];
     var event = { target: { enclosingNodeOrSelfWithNodeName: function() { return cell; } } };
 
     function sortingComplete()
@@ skipping 49 matching lines @@
 
 InspectorTest.columnContents = function(column, row)
 {
     // Make sure invisible nodes are removed from the view port.
     this._currentGrid().updateVisibleNodes();
     var result = [];
     var parent = row || this._currentGrid().rootNode();
     for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) {
         if (!node.selectable)
             continue;
-        var data = node.data[column.identifier];
-        if (typeof data === "object")
-            data = JSON.stringify(data);
-        result.push(data);
+        var cell = node.element.children[column.ordinal];
+        var content = cell.firstElementChild;
+        // Do not inlcude percents
+        if (content.firstElementChild)
+            content = content.firstElementChild;
+        result.push(content.textContent);
     }
     return result;
 };
 
 InspectorTest.countDataRows = function(row, filter)
 {
     var result = 0;
     filter = filter || function(node) { return node.selectable; };
     for (var node = row.children[0]; node; node = node.traverseNextNode(true, row, true)) {
         if (filter(node))
@@ skipping 30 matching lines @@
 };
 
 InspectorTest.findAndExpandWindow = function(callback)
 {
     InspectorTest.findAndExpandRow("Window", callback);
 };
 
 InspectorTest.findAndExpandRow = function(name, callback)
 {
     callback = InspectorTest.safeWrap(callback);
-    function propertyMatcher(data)
-    {
-        return data.value === name;
-    }
-    var row = InspectorTest.findRow("object", propertyMatcher);
+    var row = InspectorTest.findRow(name);
     InspectorTest.assertEquals(true, !!row, '"' + name + '" row');
     InspectorTest.expandRow(row, callback);
 };
 
 InspectorTest.findButtonsNode = function(row, startNode)
 {
     var result = 0;
     for (var node = startNode || row.children[0]; node; node = node.traverseNextNode(true, row, true)) {
         if (!node.selectable && node.showNext)
             return node;
     }
     return null;
 };
 
-InspectorTest.findRow = function(columnIdentifier, matcher, parent)
+InspectorTest.findRow = function(name, parent)
+{
+    function matcher(x)
+    {
+        return x._name === name;
+    };
+    return InspectorTest.findMatchingRow(matcher, parent);
+};
+
+InspectorTest.findMatchingRow = function(matcher, parent)
 {
     parent = parent || this._currentGrid().rootNode();
-    if (typeof matcher !== "function") {
-        var value = matcher;
-        matcher = function(x) { return x === value; };
-    }
     for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) {
-        if (matcher(node.data[columnIdentifier]))
+        if (matcher(node))
             return node;
     }
     return null;
-};
-
-InspectorTest.findRow2 = function(matcher, parent)
-{
-    parent = parent || this._currentGrid().rootNode();
-    for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) {
-        if (matcher(node.data))
-            return node;
-    }
-    return null;
 };
 
 InspectorTest.switchToView = function(title, callback)
 {
     callback = InspectorTest.safeWrap(callback);
     var view = WebInspector.panels.profiles.visibleView;
     view._changePerspectiveAndWait(title, callback);
     // Increase the grid container height so the viewport don't limit the number of nodes.
     InspectorTest._currentGrid().scrollContainer.style.height = "10000px";
 };
@@ skipping 43 matching lines @@
         function sortingComplete()
         {
             dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGrid.Events.SortingComplete, sortingComplete, null);
             callback();
         }
         dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Events.SortingComplete, sortingComplete, null);
     }
 };
 
 };