Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-comparison-dom-groups-change.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="heap-snapshot-test.js"></script> 4 <script src="heap-snapshot-test.js"></script>
5 <script> 5 <script>
6 6
7 function test() 7 function test()
8 { 8 {
9 function createHeapSnapshotA() 9 function createHeapSnapshotA()
10 { 10 {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 InspectorTest.takeAndOpenSnapshot(createHeapSnapshotB, step1); 88 InspectorTest.takeAndOpenSnapshot(createHeapSnapshotB, step1);
89 } 89 }
90 90
91 function step1() 91 function step1()
92 { 92 {
93 InspectorTest.switchToView("Comparison", step2); 93 InspectorTest.switchToView("Comparison", step2);
94 } 94 }
95 95
96 function step2() 96 function step2()
97 { 97 {
98 var row = InspectorTest.findRow("object", "A"); 98 var row = InspectorTest.findRow("A");
99 InspectorTest.assertEquals(true, !!row, "\"A\" row"); 99 InspectorTest.assertEquals(true, !!row, "\"A\" row");
100 InspectorTest.expandRow(row, step3); 100 InspectorTest.expandRow(row, step3);
101 } 101 }
102 102
103 function step3(row) 103 function step3(row)
104 { 104 {
105 InspectorTest.addResult("Delta: +" + row._addedCount + " -" + ro w._removedCount); 105 InspectorTest.addResult("Delta: +" + row._addedCount + " -" + ro w._removedCount);
106 var added = []; 106 var added = [];
107 var removed = []; 107 var removed = [];
108 for (var i = 0; i < row.children.length; i++) { 108 for (var i = 0; i < row.children.length; i++) {
(...skipping 14 matching lines...) Expand all
123 123
124 </script> 124 </script>
125 </head> 125 </head>
126 <body onload="runTest()"> 126 <body onload="runTest()">
127 <p> 127 <p>
128 Tests that Comparison view of heap snapshots will contain added nodes even if 128 Tests that Comparison view of heap snapshots will contain added nodes even if
129 their ids are less than the maximumm JS object id in the base snapshot. 129 their ids are less than the maximumm JS object id in the base snapshot.
130 </p> 130 </p>
131 </body> 131 </body>
132 </html> 132 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698