Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2112683003: Revert of Roll src/third_party/skia/ fc5b70a8e..f17030906 (2 commits). (Closed)

Created:
4 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dogben
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ fc5b70a8e..f17030906 (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/2109413002/ ) Reason for revert: Seems to have broken the Android Arm64 Builder: Bot Log: http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/35938/steps/compile/logs/stdio Build error: http://pastebin.com/EhNU4K2r Original issue's description: > Roll src/third_party/skia/ fc5b70a8e..f17030906 (2 commits). > > https://chromium.googlesource.com/skia.git/+log/fc5b70a8e427..f17030906dde > > $ git log fc5b70a8e..f17030906 --date=short --no-merges --format='%ad %ae %s' > 2016-06-29 bsalomon Hide more GrBatch Geometry structs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002 > 2016-06-29 bsalomon Better encapsulate oval/rrect batchs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=benjaminwagner@google.com > > Committed: https://crrev.com/322d968dbb49dfc02f2c18fd6ac91964a6e0e21f > Cr-Commit-Position: refs/heads/master@{#403136} TBR=benjaminwagner@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7b2090d38b20eb22816b06cd73b4b1da545adcd5 Cr-Commit-Position: refs/heads/master@{#403139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Primiano Tucci (use gerrit)
Created Revert of Roll src/third_party/skia/ fc5b70a8e..f17030906 (2 commits).
4 years, 5 months ago (2016-06-30 10:46:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112683003/1
4 years, 5 months ago (2016-06-30 10:47:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 10:48:34 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 10:48:39 UTC) #6
Primiano Tucci (use gerrit)
On 2016/06/30 10:48:39, commit-bot: I haz the power wrote: > CQ bit was unchecked. Uh, ...
4 years, 5 months ago (2016-06-30 10:49:14 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 10:50:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b2090d38b20eb22816b06cd73b4b1da545adcd5
Cr-Commit-Position: refs/heads/master@{#403139}

Powered by Google App Engine
This is Rietveld 408576698