Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
index bac0f5f7ecd7022ce78a0c5ae34e0eef0cd8a500..743cc06fa5511fabba8704502d7eaefdfc2a930a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
@@ -212,6 +212,15 @@ InjectedScript.prototype = {
/**
* @param {*} object
+ * @return {boolean}
+ */
+ _shouldPassByValue: function(object)
+ {
+ return typeof object === "object" && InjectedScriptHost.subtype(object) === "internal#location";
+ },
+
+ /**
+ * @param {*} object
* @param {string} groupName
* @param {boolean} canAccessInspectedGlobalObject
* @param {boolean} forceValueType
@@ -716,6 +725,13 @@ InjectedScript.RemoteObject = function(object, objectGroupName, doNotBind, force
return;
}
+ if (injectedScript._shouldPassByValue(object)) {
+ this.value = object;
+ this.subtype = injectedScript._subtype(object);
+ this.description = injectedScript._describeIncludingPrimitives(object);
+ return;
+ }
+
object = /** @type {!Object} */ (object);
if (!doNotBind)

Powered by Google App Engine
This is Rietveld 408576698