Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index f4bef520da7b59be744c2975fdfcbf84505c7ad5..3cb238abf44b3e4c07ddc624556d79e9dc18b434 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -952,8 +952,6 @@ WebInspector.SourcesPanel.prototype = {
contextMenu.appendItem(WebInspector.UIString.capitalize("Store as ^global ^variable"), this._saveToTempVariable.bind(this, remoteObject));
if (remoteObject.type === "function")
contextMenu.appendItem(WebInspector.UIString.capitalize("Show ^function ^definition"), this._showFunctionDefinition.bind(this, remoteObject));
- if (remoteObject.subtype === "generator")
- contextMenu.appendItem(WebInspector.UIString.capitalize("Show ^generator ^location"), this._showGeneratorLocation.bind(this, remoteObject));
},
/**
@@ -1042,21 +1040,13 @@ WebInspector.SourcesPanel.prototype = {
*/
_showFunctionDefinition: function(remoteObject)
{
- remoteObject.debuggerModel().functionDetails(remoteObject, this._didGetFunctionOrGeneratorObjectDetails.bind(this));
- },
-
- /**
- * @param {!WebInspector.RemoteObject} remoteObject
- */
- _showGeneratorLocation: function(remoteObject)
- {
- remoteObject.debuggerModel().generatorObjectDetails(remoteObject, this._didGetFunctionOrGeneratorObjectDetails.bind(this));
+ remoteObject.debuggerModel().functionDetails(remoteObject, this._didGetFunctionDetails.bind(this));
},
/**
* @param {?{location: ?WebInspector.DebuggerModel.Location}} response
*/
- _didGetFunctionOrGeneratorObjectDetails: function(response)
+ _didGetFunctionDetails: function(response)
{
if (!response || !response.location)
return;

Powered by Google App Engine
This is Rietveld 408576698