third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js - Issue 2112673003: [DevTools] Move suspended generator location to internal properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

index 6b0dc58929f84bc35c391b84c7bc72092af78517..f0a14e92eaf45e1bbaa5625158449659086f8c47 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

@@ -32,6 +32,7 @@ WebInspector.ScopeChainSidebarPane = function()

{

WebInspector.SidebarPane.call(this, WebInspector.UIString("Scope"));

this._expandController = new WebInspector.ObjectPropertiesSectionExpandController();

+ this._linkifier = new WebInspector.Linkifier();

}

WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path");

@@ -42,6 +43,7 @@ WebInspector.ScopeChainSidebarPane.prototype = {

update: function(callFrame)

{

+ this._linkifier.reset();

WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame)

.then(this._innerUpdate.bind(this, callFrame));

@@ -120,7 +122,7 @@ WebInspector.ScopeChainSidebarPane.prototype = {

titleElement.createChild("div", "scope-chain-sidebar-pane-section-subtitle").textContent = subtitle;

titleElement.createChild("div", "scope-chain-sidebar-pane-section-title").textContent = title;

- var section = new WebInspector.ObjectPropertiesSection(WebInspector.SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, emptyPlaceholder, true, extraProperties);

+ var section = new WebInspector.ObjectPropertiesSection(WebInspector.SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, this._linkifier, emptyPlaceholder, true, extraProperties);

this._expandController.watchSection(title + (subtitle ? ":" + subtitle : ""), section);

if (scope.type() === DebuggerAgent.ScopeType.Global)