Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index ca13c117286e8547f04f5c32b08ef921c4301aca..aa928e594ab7eb4bd2971ab130001827a4f95c43 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -61,9 +61,6 @@ WebInspector.DebuggerModel = function(target)
/** @typedef {{location: ?WebInspector.DebuggerModel.Location, sourceURL: ?string, functionName: string, scopeChain: (Array.<!DebuggerAgent.Scope>|null)}} */
WebInspector.DebuggerModel.FunctionDetails;
-/** @typedef {{location: ?WebInspector.DebuggerModel.Location, sourceURL: ?string, functionName: string, status: string}} */
-WebInspector.DebuggerModel.GeneratorObjectDetails;
-
/**
* Keep these in sync with WebCore::V8Debugger
*
@@ -716,34 +713,6 @@ WebInspector.DebuggerModel.prototype = {
},
/**
- * @param {!WebInspector.RemoteObject} remoteObject
- * @param {function(?WebInspector.DebuggerModel.GeneratorObjectDetails)} callback
- */
- generatorObjectDetails: function(remoteObject, callback)
- {
- this._agent.getGeneratorObjectDetails(remoteObject.objectId, didGetDetails.bind(this));
-
- /**
- * @param {?Protocol.Error} error
- * @param {!DebuggerAgent.GeneratorObjectDetails} response
- * @this {WebInspector.DebuggerModel}
- */
- function didGetDetails(error, response)
- {
- if (error) {
- console.error(error);
- callback(null);
- return;
- }
- var location = response.location;
- var script = location && this.scriptForId(location.scriptId);
- var rawLocation = script ? this.createRawLocation(script, location.lineNumber, location.columnNumber || 0) : null;
- var sourceURL = script ? script.contentURL() : null;
- callback({location: rawLocation, sourceURL: sourceURL, functionName: response.functionName, status: response.status});
- }
- },
-
- /**
* @param {!DebuggerAgent.BreakpointId} breakpointId
* @param {function(!WebInspector.Event)} listener
* @param {!Object=} thisObject

Powered by Google App Engine
This is Rietveld 408576698