Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
index f2baae211d320e8dc4e830892735c13b742e5291..7ed9f38dbc4eeaec1fe0843f7d8b26055ffe37a2 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
@@ -112,23 +112,6 @@ WebInspector.ObjectPopoverHelper.prototype = {
}
/**
- * @param {?WebInspector.DebuggerModel.GeneratorObjectDetails} response
- * @this {WebInspector.ObjectPopoverHelper}
- */
- function didGetGeneratorObjectDetails(response)
- {
- if (!response || popover.disposed)
- return;
-
- var rawLocation = response.location;
- var sourceURL = response.sourceURL;
- if (rawLocation && sourceURL) {
- var link = this._lazyLinkifier().linkifyRawLocation(rawLocation, sourceURL, "function-location-link");
- this._titleElement.appendChild(link);
- }
- }
-
- /**
* @param {!WebInspector.RemoteObject} result
* @param {boolean} wasThrown
* @param {!Element=} anchorOverride
@@ -182,7 +165,7 @@ WebInspector.ObjectPopoverHelper.prototype = {
popoverContentElement.appendChild(section.element);
if (result.subtype === "generator")
- result.generatorObjectDetails(didGetGeneratorObjectDetails.bind(this));
+ result.debuggerModel().generatorObjectLocation(result).then(addGeneratorLocation.bind(this));
}
var popoverWidth = 300;
var popoverHeight = 250;
@@ -190,6 +173,20 @@ WebInspector.ObjectPopoverHelper.prototype = {
}
}
+ /**
+ * @param {?WebInspector.DebuggerModel.Location} location
+ * @this {WebInspector.ObjectPopoverHelper}
+ */
+ function addGeneratorLocation(location)
+ {
+ if (!location)
+ return;
+ var script = location.script();
+ var sourceURL = script ? script.sourceURL : "";
+ var link = this._lazyLinkifier().linkifyRawLocation(location, sourceURL, "function-location-link");
+ this._titleElement.appendChild(link);
+ }
+
this._queryObject(element, didQueryObject.bind(this), this._popoverObjectGroup);
},

Powered by Google App Engine
This is Rietveld 408576698