[DevTools] Move suspended generator location to internal properties

third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 44 matching lines @@
     WebInspector.moduleSetting("pauseOnExceptionEnabled").addChangeListener(this._pauseOnExceptionStateChanged, this);
     WebInspector.moduleSetting("pauseOnCaughtException").addChangeListener(this._pauseOnExceptionStateChanged, this);
     WebInspector.moduleSetting("enableAsyncStackTraces").addChangeListener(this.asyncStackTracesStateChanged, this);
 
     this.enableDebugger();
 }
 
 /** @typedef {{location: ?WebInspector.DebuggerModel.Location, sourceURL: ?string, functionName: string, scopeChain: (Array.<!DebuggerAgent.Scope>|null)}} */
 WebInspector.DebuggerModel.FunctionDetails;
 
-/** @typedef {{location: ?WebInspector.DebuggerModel.Location, sourceURL: ?string, functionName: string, status: string}} */
-WebInspector.DebuggerModel.GeneratorObjectDetails;
-
 /**
  * Keep these in sync with WebCore::V8Debugger
  *
  * @enum {string}
  */
 WebInspector.DebuggerModel.PauseOnExceptionsState = {
     DontPauseOnExceptions : "none",
     PauseOnAllExceptions : "all",
     PauseOnUncaughtExceptions: "uncaught"
 };
@@ skipping 633 matching lines @@
                     callback(error);
                 return;
             }
             if (callback)
                 callback();
         }
     },
 
     /**
      * @param {!WebInspector.RemoteObject} remoteObject
-     * @param {function(?WebInspector.DebuggerModel.GeneratorObjectDetails)} callback
+     * @return {!Promise<?WebInspector.DebuggerModel.Location>}
      */
-    generatorObjectDetails: function(remoteObject, callback)
+    generatorObjectLocation: function(remoteObject)

[dgozman, 2016/07/07 00:44:34]

I think we don't use this.

[kozy, 2016/07/07 17:58:02]

Done.

     {
-        this._agent.getGeneratorObjectDetails(remoteObject.objectId, didGetDetails.bind(this));
+        if (remoteObject.subtype !== "generator")
+            return Promise.resolve(/** @type {?WebInspector.DebuggerModel.Location} */(null));
+        return remoteObject.getOwnPropertiesPromise().then(buildLocation.bind(this));
 
         /**
-         * @param {?Protocol.Error} error
-         * @param {!DebuggerAgent.GeneratorObjectDetails} response
-         * @this {WebInspector.DebuggerModel}
+         * @this {!WebInspector.DebuggerModel}
+         * @param {!{properties: ?Array.<!WebInspector.RemoteObjectProperty>, internalProperties: ?Array.<!WebInspector.RemoteObjectProperty>}} response
+         * @return {?WebInspector.DebuggerModel.Location}
          */
-        function didGetDetails(error, response)
+        function buildLocation(response)
         {
-            if (error) {
-                console.error(error);
-                callback(null);
-                return;
+            if (!response || !response.internalProperties)
+                return null;
+            for (var prop of response.internalProperties) {
+                if (prop.name === "[[GeneratorLocation]]") {
+                    var loc = prop.value.value;
+                    return this.createRawLocationByScriptId(loc.scriptId, loc.lineNumber, loc.columnNumber);
+                }
             }
-            var location = response.location;
-            var script = location && this.scriptForId(location.scriptId);
-            var rawLocation = script ? this.createRawLocation(script, location.lineNumber, location.columnNumber || 0) : null;
-            var sourceURL = script ? script.contentURL() : null;
-            callback({location: rawLocation, sourceURL: sourceURL, functionName: response.functionName, status: response.status});
+            return null;
         }
     },
 
     /**
      * @param {!DebuggerAgent.BreakpointId} breakpointId
      * @param {function(!WebInspector.Event)} listener
      * @param {!Object=} thisObject
      */
     addBreakpointListener: function(breakpointId, listener, thisObject)
     {
@@ skipping 568 matching lines @@
 /**
  * @param {?WebInspector.Target} target
  * @return {?WebInspector.DebuggerModel}
  */
 WebInspector.DebuggerModel.fromTarget = function(target)
 {
     if (!target || !target.hasJSContext())
         return null;
     return /** @type {?WebInspector.DebuggerModel} */ (target.model(WebInspector.DebuggerModel));
 }