Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-generator-location.html

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../../http/tests/inspector/inspector-test.js"></script>
4 <script src="../../../http/tests/inspector/console-test.js"></script> 4 <script src="../../../http/tests/inspector/console-test.js"></script>
5 <script> 5 <script>
6 6
7 function forward(iter, step) 7 function forward(iter, step)
8 { 8 {
9 while (step-- > 0) 9 while (step-- > 0)
10 iter.next(); 10 iter.next();
(...skipping 17 matching lines...) Expand all
28 { 28 {
29 var panel = WebInspector.panels.sources; 29 var panel = WebInspector.panels.sources;
30 30
31 function performStandardTestCase(pageExpression, next) 31 function performStandardTestCase(pageExpression, next)
32 { 32 {
33 InspectorTest.addSniffer(panel, "showUISourceCode", showUISourceCodeHook ); 33 InspectorTest.addSniffer(panel, "showUISourceCode", showUISourceCodeHook );
34 InspectorTest.evaluateInPage(pageExpression, didEvaluate); 34 InspectorTest.evaluateInPage(pageExpression, didEvaluate);
35 35
36 function didEvaluate(remote) 36 function didEvaluate(remote)
37 { 37 {
38 panel._showGeneratorLocation(remote); 38 remote.debuggerModel().generatorObjectLocation(remote).then(loc => W ebInspector.Revealer.reveal(loc));
39 } 39 }
40 40
41 function showUISourceCodeHook(uiSourceCode, lineNumber, columnNumber, fo rceShowInPanel) 41 function showUISourceCodeHook(uiSourceCode, lineNumber, columnNumber, fo rceShowInPanel)
42 { 42 {
43 // lineNumber and columnNumber are 0-based 43 // lineNumber and columnNumber are 0-based
44 ++lineNumber; 44 ++lineNumber;
45 ++columnNumber; 45 ++columnNumber;
46 InspectorTest.addResult("Generator location revealed: [" + lineNumbe r + ":" + columnNumber + "]"); 46 InspectorTest.addResult("Generator location revealed: [" + lineNumbe r + ":" + columnNumber + "]");
47 next(); 47 next();
48 } 48 }
(...skipping 21 matching lines...) Expand all
70 70
71 </script> 71 </script>
72 </head> 72 </head>
73 73
74 <body onload="runTest()"> 74 <body onload="runTest()">
75 <p> 75 <p>
76 Tests that "Show Generator Location" jumps to the correct location. 76 Tests that "Show Generator Location" jumps to the correct location.
77 </p> 77 </p>
78 </body> 78 </body>
79 </html> 79 </html>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698