Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2112673003: [DevTools] Move suspended generator location to internal properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1030 matching lines...) Expand 10 before | Expand all | Expand 10 after
1041 * @param {!WebInspector.RemoteObject} remoteObject 1041 * @param {!WebInspector.RemoteObject} remoteObject
1042 */ 1042 */
1043 _showFunctionDefinition: function(remoteObject) 1043 _showFunctionDefinition: function(remoteObject)
1044 { 1044 {
1045 remoteObject.debuggerModel().functionDetails(remoteObject, this._didGetF unctionOrGeneratorObjectDetails.bind(this)); 1045 remoteObject.debuggerModel().functionDetails(remoteObject, this._didGetF unctionOrGeneratorObjectDetails.bind(this));
1046 }, 1046 },
1047 1047
1048 /** 1048 /**
1049 * @param {!WebInspector.RemoteObject} remoteObject 1049 * @param {!WebInspector.RemoteObject} remoteObject
1050 */ 1050 */
1051 _showGeneratorLocation: function(remoteObject) 1051 _showGeneratorLocation: function(remoteObject)
dgozman 2016/07/06 19:25:12 Let's remove this and rely on ObjectPropertiesSect
kozy 2016/07/06 22:38:41 Done.
1052 { 1052 {
1053 remoteObject.debuggerModel().generatorObjectDetails(remoteObject, this._ didGetFunctionOrGeneratorObjectDetails.bind(this)); 1053 remoteObject.debuggerModel().generatorObjectLocation(remoteObject)
1054 .then(location => ({ location: location }))
1055 .then(this._didGetFunctionOrGeneratorObjectDetails.bind(this));
1054 }, 1056 },
1055 1057
1056 /** 1058 /**
1057 * @param {?{location: ?WebInspector.DebuggerModel.Location}} response 1059 * @param {?{location: ?WebInspector.DebuggerModel.Location}} response
1058 */ 1060 */
1059 _didGetFunctionOrGeneratorObjectDetails: function(response) 1061 _didGetFunctionOrGeneratorObjectDetails: function(response)
1060 { 1062 {
1061 if (!response || !response.location) 1063 if (!response || !response.location)
1062 return; 1064 return;
1063 1065
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1482 __proto__: WebInspector.VBox.prototype 1484 __proto__: WebInspector.VBox.prototype
1483 } 1485 }
1484 1486
1485 /** 1487 /**
1486 * @return {boolean} 1488 * @return {boolean}
1487 */ 1489 */
1488 WebInspector.SourcesPanel.WrapperView.isShowing = function() 1490 WebInspector.SourcesPanel.WrapperView.isShowing = function()
1489 { 1491 {
1490 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing(); 1492 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing();
1491 } 1493 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698