Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4635)

Unified Diff: chrome/browser/media/router/mojo/media_router.mojom

Issue 2112673002: Removing references to Off the Record from MediaRouter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More refactoring Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index 816527e1d1d0c9cd3d1fc8f3cc37cb230a49a85a..572ef48428934f736c88a74b4d6fb24d53249c83 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -46,9 +46,8 @@ struct MediaRoute {
string? custom_controller_path;
// Set to true if this route should be displayed for |media_sink_id| in UI.
bool for_display;
- // Set to true if this route was created by an off the record (incognito)
- // profile.
- bool off_the_record;
+ // Set to true if this route was created by an incognito profile.
+ bool incognito;
};
// Notifications or an actionable events to be shown to the user.
@@ -147,8 +146,7 @@ interface MediaRouteProvider {
// If |timeout_millis| is positive, it will be used in place of the default
// timeout defined by Media Route Provider Manager.
//
- // If |off_the_record| is true, the request was made by an off the record
- // (incognito) profile.
+ // If |incognito| is true, the request was made by an incognito profile.
//
// If the operation was successful, |route| will be defined and
// |error_text| will be null.
@@ -162,7 +160,7 @@ interface MediaRouteProvider {
string origin,
int32 tab_id,
int64 timeout_millis,
- bool off_the_record) =>
+ bool incognito) =>
(MediaRoute? route,
string? error_text,
RouteRequestResultCode result_code);
@@ -176,8 +174,8 @@ interface MediaRouteProvider {
// If |timeout_millis| is positive, it will be used in place of the default
// timeout defined by Media Route Provider Manager.
//
- // If the route request was created by an off the record (incognito) profile,
- // |off_the_record| must be true.
+ // If the route request was created by an incognito profile,
+ // |incognito| must be true.
//
// If the operation was successful, |route| will be defined and
// |error_text| will be null.
@@ -190,7 +188,7 @@ interface MediaRouteProvider {
string origin,
int32 tab_id,
int64 timeout_millis,
- bool off_the_record) =>
+ bool incognito) =>
(MediaRoute? route,
string? error_text,
RouteRequestResultCode result_code);
@@ -209,8 +207,8 @@ interface MediaRouteProvider {
// timeout defined by Media Route Provider Manager; see CreateRoute for additional
// documentation.
//
- // If the route request was created by an off the record (incognito) profile,
- // |off_the_record| must be true.
+ // If the route request was created by an incognito profile,
+ // |incognito| must be true.
//
// If the operation was successful, |route| will be defined and
// |error_text| will be null. If the operation failed, |route| will be null
@@ -224,7 +222,7 @@ interface MediaRouteProvider {
string origin,
int32 tab_id,
int64 timeout_millis,
- bool off_the_record) =>
+ bool incognito) =>
(MediaRoute? route,
string? error_text,
RouteRequestResultCode result_code);

Powered by Google App Engine
This is Rietveld 408576698