Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: extensions/renderer/resources/media_router_bindings.js

Issue 2112673002: Removing references to Off the Record from MediaRouter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More refactoring on rebased code Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/media_router/media_router_e2e_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/media_router_bindings.js
diff --git a/extensions/renderer/resources/media_router_bindings.js b/extensions/renderer/resources/media_router_bindings.js
index 30434e1c54a32da5e512e1b796ebfe1dcd8d5953..263e4dd730d76ba0330d4feec85ee7df7e9bcf6a 100644
--- a/extensions/renderer/resources/media_router_bindings.js
+++ b/extensions/renderer/resources/media_router_bindings.js
@@ -78,7 +78,7 @@ define('media_router_bindings', [
// Begin newly added properties, followed by the milestone they were
// added. The guard should be safe to remove N+2 milestones later.
'for_display': route.forDisplay, // M47
- 'off_the_record': !!route.offTheRecord // M50
+ 'incognito': !!route.offTheRecord // M50
});
}
@@ -603,18 +603,18 @@ define('media_router_bindings', [
* @param {!number} timeoutMillis If positive, the timeout duration for the
* request, measured in seconds. Otherwise, the default duration will be
* used.
- * @param {!boolean} offTheRecord If true, the route is being requested by
- * an off the record (incognito) profile.
+ * @param {!boolean} incognito If true, the route is being requested by
+ * an incognito profile.
* @return {!Promise.<!Object>} A Promise resolving to an object describing
* the newly created media route, or rejecting with an error message on
* failure.
*/
MediaRouteProvider.prototype.createRoute =
function(sourceUrn, sinkId, presentationId, origin, tabId,
- timeoutMillis, offTheRecord) {
+ timeoutMillis, incognito) {
return this.handlers_.createRoute(
sourceUrn, sinkId, presentationId, origin, tabId, timeoutMillis,
- offTheRecord)
+ incognito)
.then(function(route) {
return toSuccessRouteResponse_(route);
},
@@ -634,17 +634,17 @@ define('media_router_bindings', [
* @param {!number} timeoutMillis If positive, the timeout duration for the
* request, measured in seconds. Otherwise, the default duration will be
* used.
- * @param {!boolean} offTheRecord If true, the route is being requested by
- * an off the record (incognito) profile.
+ * @param {!boolean} incognito If true, the route is being requested by
+ * an incognito profile.
* @return {!Promise.<!Object>} A Promise resolving to an object describing
* the newly created media route, or rejecting with an error message on
* failure.
*/
MediaRouteProvider.prototype.joinRoute =
function(sourceUrn, presentationId, origin, tabId, timeoutMillis,
- offTheRecord) {
+ incognito) {
return this.handlers_.joinRoute(
- sourceUrn, presentationId, origin, tabId, timeoutMillis, offTheRecord)
+ sourceUrn, presentationId, origin, tabId, timeoutMillis, incognito)
.then(function(route) {
return toSuccessRouteResponse_(route);
},
@@ -665,18 +665,18 @@ define('media_router_bindings', [
* @param {!number} timeoutMillis If positive, the timeout duration for the
* request, measured in seconds. Otherwise, the default duration will be
* used.
- * @param {!boolean} offTheRecord If true, the route is being requested by
- * an off the record (incognito) profile.
+ * @param {!boolean} incognito If true, the route is being requested by
+ * an incognito profile.
* @return {!Promise.<!Object>} A Promise resolving to an object describing
* the newly created media route, or rejecting with an error message on
* failure.
*/
MediaRouteProvider.prototype.connectRouteByRouteId =
function(sourceUrn, routeId, presentationId, origin, tabId,
- timeoutMillis, offTheRecord) {
+ timeoutMillis, incognito) {
return this.handlers_.connectRouteByRouteId(
sourceUrn, routeId, presentationId, origin, tabId, timeoutMillis,
- offTheRecord)
+ incognito)
.then(function(route) {
return toSuccessRouteResponse_(route);
},
« no previous file with comments | « chrome/test/media_router/media_router_e2e_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698