chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc - Issue 2112673002: Removing references to Off the Record from MediaRouter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2112673002: Removing references to Off the Record from MediaRouter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More refactoring on rebased code Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/media/router/route_request_result.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

index e08ef510cc1eea738707946def5e3d3ee41d5708..6d4aa38b187247581a20b18d37758dbd1cea107c 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

@@ -78,7 +78,7 @@ class PresentationServiceDelegateImplTest

protected:

virtual content::WebContents* GetWebContents() { return web_contents(); }

- void RunDefaultPresentationUrlCallbackTest(bool off_the_record) {

+ void RunDefaultPresentationUrlCallbackTest(bool incognito) {

content::RenderFrameHost* main_frame = GetWebContents()->GetMainFrame();

ASSERT_TRUE(main_frame);

int render_process_id = main_frame->GetProcess()->GetID();

@@ -109,7 +109,7 @@ class PresentationServiceDelegateImplTest

MediaRoute* media_route = new MediaRoute(

"differentRouteId", MediaSourceForPresentationUrl(presentation_url2),

"mediaSinkId", "", true, "", true);

- media_route->set_off_the_record(off_the_record);

+ media_route->set_incognito(incognito);

result = RouteRequestResult::FromSuccess(base::WrapUnique(media_route),

"differentPresentationId");

delegate_impl_->OnRouteResponse(different_request, *result);

@@ -120,7 +120,7 @@ class PresentationServiceDelegateImplTest

MediaRoute* media_route2 = new MediaRoute(

"routeId", MediaSourceForPresentationUrl(presentation_url1),

"mediaSinkId", "", true, "", true);

- media_route2->set_off_the_record(off_the_record);

+ media_route2->set_incognito(incognito);

result = RouteRequestResult::FromSuccess(base::WrapUnique(media_route2),

"presentationId");

delegate_impl_->OnRouteResponse(request, *result);