chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc - Issue 2112673002: Removing references to Off the Record from MediaRouter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

Issue 2112673002: Removing references to Off the Record from MediaRouter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More refactoring on rebased code Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/mojo/media_router_type_converters.cc ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

diff --git a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

index 31994662cd6008726809083a04bd0ea83729df87..27c50e9238bfbbbc90c6c91c6523286339cd175a 100644

--- a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

+++ b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

@@ -76,7 +76,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaRoute) {

MediaSource expected_source(MediaSourceForTab(123));

MediaRoute expected_media_route("routeId1", expected_source, "sinkId",

"Description", false, "cast_view.html", true);

- expected_media_route.set_off_the_record(true);

+ expected_media_route.set_incognito(true);

interfaces::MediaRoutePtr mojo_route(interfaces::MediaRoute::New());

mojo_route->media_route_id = "routeId1";

mojo_route->media_source = expected_source.id();

@@ -85,7 +85,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaRoute) {

mojo_route->is_local = false;

mojo_route->custom_controller_path = "cast_view.html";

mojo_route->for_display = true;

- mojo_route->off_the_record = true;

+ mojo_route->incognito = true;

MediaRoute media_route = mojo_route.To<MediaRoute>();

EXPECT_TRUE(expected_media_route.Equals(media_route));

@@ -99,8 +99,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaRoute) {

EXPECT_EQ(expected_media_route.custom_controller_path(),

media_route.custom_controller_path());

EXPECT_EQ(expected_media_route.for_display(), media_route.for_display());

- EXPECT_EQ(expected_media_route.off_the_record(),

- media_route.off_the_record());

+ EXPECT_EQ(expected_media_route.incognito(), media_route.incognito());

}

TEST(MediaRouterTypeConvertersTest, ConvertMediaRouteWithoutOptionalFields) {

@@ -113,7 +112,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaRouteWithoutOptionalFields) {

mojo_route->description = "Description";

mojo_route->is_local = false;

mojo_route->for_display = false;

- mojo_route->off_the_record = false;

+ mojo_route->incognito = false;

MediaRoute media_route = mojo_route.To<MediaRoute>();

EXPECT_TRUE(expected_media_route.Equals(media_route));