Add device_serial

Adding in @property device_serial. This property will be used in local_device_environment to add the device serials to associated logcat files.
BUG=chromium:448050

[nicholaslin, 2016-06-29 22:24:25]

nicholaslin@google.com changed reviewers:
+ jbudorick@chromium.org, stip@chromium.org

[nicholaslin, 2016-06-29 22:24:26]

Adding Logdog arguments for streaming logcats to logdog. PTAL.

[jbudorick, 2016-06-30 08:15:34]

Need a bit more context here -- how & where will this get used? What do the
instance variables do?

[nicholaslin, 2016-06-30 10:35:49]

On 2016/06/30 08:15:34, jbudorick (EMEA til June 30) wrote:
> Need a bit more context here -- how & where will this get used? What do the
> instance variables do?

For swarming tasks on android, we intend to create a unified logcat view using
logdog. These variables will be used to stream device logcats onto the
logdog_butler which will store the logs permanently on google storage.

A logdog butler stream looks like [prefix]/+/[stream_name] where:
1. each logdog butler must have a unique [prefix] 
2. each stream to the butler is [stream_name] 

The logdog_prefix variable is the [prefix] and the logdog_name is the
[stream_name] for each devices' logcat stream. These variables will be used to
create the logdog stream, most likely in the _StartRecording() function.

[jbudorick, 2016-06-30 11:24:48]

On 2016/06/30 10:35:49, nicholaslin wrote:
> On 2016/06/30 08:15:34, jbudorick (EMEA til June 30) wrote:
> > Need a bit more context here -- how & where will this get used? What do the
> > instance variables do?
> 
> For swarming tasks on android, we intend to create a unified logcat view using
> logdog. These variables will be used to stream device logcats onto the
> logdog_butler which will store the logs permanently on google storage.
> 
> A logdog butler stream looks like [prefix]/+/[stream_name] where:
> 1. each logdog butler must have a unique [prefix] 
> 2. each stream to the butler is [stream_name] 
> 
> The logdog_prefix variable is the [prefix] and the logdog_name is the
> [stream_name] for each devices' logcat stream. These variables will be used to
> create the logdog stream, most likely in the _StartRecording() function.

1) I guess I'm still confused because this CL doesn't do anything.
2) It's not clear to me why this should be in devil rather than somewhere in
infra.

[nicholaslin, 2016-06-30 18:24:15]

On 2016/06/30 11:24:48, jbudorick (EMEA til June 30) wrote:
> On 2016/06/30 10:35:49, nicholaslin wrote:
> > On 2016/06/30 08:15:34, jbudorick (EMEA til June 30) wrote:
> > > Need a bit more context here -- how & where will this get used? What do
the
> > > instance variables do?
> > 
> > For swarming tasks on android, we intend to create a unified logcat view
using
> > logdog. These variables will be used to stream device logcats onto the
> > logdog_butler which will store the logs permanently on google storage.
> > 
> > A logdog butler stream looks like [prefix]/+/[stream_name] where:
> > 1. each logdog butler must have a unique [prefix] 
> > 2. each stream to the butler is [stream_name] 
> > 
> > The logdog_prefix variable is the [prefix] and the logdog_name is the
> > [stream_name] for each devices' logcat stream. These variables will be used
to
> > create the logdog stream, most likely in the _StartRecording() function.
> 
> 1) I guess I'm still confused because this CL doesn't do anything.
> 2) It's not clear to me why this should be in devil rather than somewhere in
> infra.

From what I understand, the arguments for logcats seem to follow the order
test_runner.py -> local_device_monitor -> logcat_monitor, where the logcats are
written to file. To me, this seems to be the best place to add the logdog
streaming support. I have other changes to test_runner and
local_device_environment that will populate the variables fed into the
logcat_monitor (https://codereview.chromium.org/2105383004/#ps20001). However,
right now I am getting exceptions as these changes depend on logcat_monitor.

Right now my plan is to:
1. Add/land these fields in logcat monitor.
2. Add/land the extra arguments in test_runner and local_device_monitor.
[up to this point everything works locally]
3. Work on streaming the logcats to logdog: changes to this file +
local_device_monitor.
4. Work on recipes and configure the options to display logdog on the buildbot
page.

[jbudorick, 2016-07-01 14:29:51]

On 2016/06/30 18:24:15, nicholaslin wrote:
> On 2016/06/30 11:24:48, jbudorick (EMEA til June 30) wrote:
> > On 2016/06/30 10:35:49, nicholaslin wrote:
> > > On 2016/06/30 08:15:34, jbudorick (EMEA til June 30) wrote:
> > > > Need a bit more context here -- how & where will this get used? What do
> the
> > > > instance variables do?
> > > 
> > > For swarming tasks on android, we intend to create a unified logcat view
> using
> > > logdog. These variables will be used to stream device logcats onto the
> > > logdog_butler which will store the logs permanently on google storage.
> > > 
> > > A logdog butler stream looks like [prefix]/+/[stream_name] where:
> > > 1. each logdog butler must have a unique [prefix] 
> > > 2. each stream to the butler is [stream_name] 
> > > 
> > > The logdog_prefix variable is the [prefix] and the logdog_name is the
> > > [stream_name] for each devices' logcat stream. These variables will be
used
> to
> > > create the logdog stream, most likely in the _StartRecording() function.
> > 
> > 1) I guess I'm still confused because this CL doesn't do anything.
> > 2) It's not clear to me why this should be in devil rather than somewhere in
> > infra.
> 
> From what I understand, the arguments for logcats seem to follow the order
> test_runner.py -> local_device_monitor -> logcat_monitor, where the logcats
are
> written to file. To me, this seems to be the best place to add the logdog
> streaming support. I have other changes to test_runner and
> local_device_environment that will populate the variables fed into the
> logcat_monitor (https://codereview.chromium.org/2105383004/#ps20001). However,
> right now I am getting exceptions as these changes depend on logcat_monitor.
> 
> Right now my plan is to:
> 1. Add/land these fields in logcat monitor.
> 2. Add/land the extra arguments in test_runner and local_device_monitor.
> [up to this point everything works locally]
> 3. Work on streaming the logcats to logdog: changes to this file +
> local_device_monitor.
> 4. Work on recipes and configure the options to display logdog on the buildbot
> page.

Let's talk about this. I'll set up a meeting.

[nicholaslin, 2016-07-13 00:29:34]

Description was changed from

==========
Add Logdog placeholders.

BUG=chromium:448050
==========

to

==========
Adding in @property device_serial. This property will be used in
local_device_environment to add the device serials to associated logcat files.
BUG=chromium:448050
==========

[nicholaslin, 2016-07-13 01:27:01]

Deleting all logdog logic since streaming will be done elsewhere. Adding in a
new property to get the logcat device_serial. This property will be used in
https://codereview.chromium.org/2130863002 once those changes are finalized.
PTAL.