Replace "Remove from Chrome..." in the action context menu with "Remove icon"

Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104
Committed: https://crrev.com/febe3507454b00c47fd0454d5267fb288dcf72b0
Cr-Commit-Position: refs/heads/master@{#403314}

[takumif, 2016-06-29 18:25:38]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[takumif, 2016-06-29 18:26:45]

Description was changed from

==========
Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
So we are replacing the text with "Remove icon".

BUG=624104
==========

to

==========
Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104
==========

[commit-bot: I haz the power, 2016-06-29 18:27:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 18:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 18:27:02]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[takumif, 2016-06-29 22:19:11]

takumif@chromium.org changed reviewers:
+ apacible@chromium.org, cpu@chromium.org, mfoltz@chromium.org,
skonig@chromium.org

[takumif, 2016-06-29 22:19:11]

Please take a look, thank you!
+cpu@ for editing a .grdp

[apacible, 2016-06-30 16:57:56]

lgtm+tiny nit

Per the grdp change: imcheng, mfoltz, and I are OWNERS[1] for the file. For
future MR specific grdp changes, including media_router_resources.grdp, you can
just include one of us.

[2] https://cs.chromium.org/chromium/src/chrome/app/OWNERS?l=17-19

https://codereview.chromium.org/2112623002/diff/1/chrome/app/media_router_str...
File chrome/app/media_router_strings.grdp (right):

https://codereview.chromium.org/2112623002/diff/1/chrome/app/media_router_str...
chrome/app/media_router_strings.grdp:69: <message
name="IDS_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION" desc="Title of a menu item which,
on click, removes the Media Router action from the toolbar.">
nit: "...the Media Router Action icon..."

[mark a. foltz, 2016-06-30 18:17:41]

lgtm

[takumif, 2016-06-30 19:00:37]

Patchset #2 (id:20001) has been deleted

[takumif, 2016-06-30 19:38:50]

takumif@chromium.org changed reviewers:
+ msw@chromium.org
- cpu@chromium.org

[takumif, 2016-06-30 19:38:50]

+msw@ for OWNERS  chrome/browser/ui/toolbar/media_router_contextual_menu.cc

[msw, 2016-06-30 19:43:01]

lgtm; presumably there's some way to add it back?

[takumif, 2016-06-30 19:49:55]

On 2016/06/30 19:43:01, msw wrote:
> lgtm; presumably there's some way to add it back?

The BUG (624104) discusses the reasoning behind this change.
Currently users can add the icon by installing the Cast extension from the Web
Store.

Once we implement the ephemeral icon [1], whenever the user is using Cast
functionalities the icon will be temporarily visible, and there will be an
option in the context menu to pin the icon. 

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=594577

[takumif, 2016-06-30 21:30:36]

The CQ bit was checked by takumif@chromium.org

[takumif, 2016-06-30 21:30:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
apacible@chromium.org
Link to the patchset: https://codereview.chromium.org/2112623002/#ps40001
(title: "Address apacible@'s comment, rebase")

[commit-bot: I haz the power, 2016-06-30 21:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 22:19:45]

Description was changed from

==========
Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104
==========

to

==========
Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104
==========

[commit-bot: I haz the power, 2016-06-30 22:19:46]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-30 22:22:36]

Description was changed from

==========
Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104
==========

to

==========
Replace "Remove from Chrome..." in the action context menu with "Remove icon"

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104

Committed: https://crrev.com/febe3507454b00c47fd0454d5267fb288dcf72b0
Cr-Commit-Position: refs/heads/master@{#403314}
==========

[commit-bot: I haz the power, 2016-06-30 22:22:37]

Patchset 2 (id:??) landed as
https://crrev.com/febe3507454b00c47fd0454d5267fb288dcf72b0
Cr-Commit-Position: refs/heads/master@{#403314}