Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2112603003: Add pixel test for solid color backgrounds. (Closed)

Created:
4 years, 5 months ago by vmiura
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pixel test for solid color backgrounds. This catches issues with compositing solid color quads. Test is initially expected to fail until reference images are generated. R=kbr@chromium.org BUG=624256 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/8dcc2faa7b3d7a6c57f1c3a9492a132a4f2b9373 Cr-Commit-Position: refs/heads/master@{#403193}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M content/test/data/gpu/pixel_background.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +5 lines, -0 lines 1 comment Download
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
vmiura
ptal
4 years, 5 months ago (2016-06-30 02:29:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112603003/1
4 years, 5 months ago (2016-06-30 02:32:46 UTC) #4
Ken Russell (switch to Gerrit)
Great. LGTM https://codereview.chromium.org/2112603003/diff/1/content/test/gpu/gpu_tests/pixel_expectations.py File content/test/gpu/gpu_tests/pixel_expectations.py (right): https://codereview.chromium.org/2112603003/diff/1/content/test/gpu/gpu_tests/pixel_expectations.py#newcode25 content/test/gpu/gpu_tests/pixel_expectations.py:25: self.Fail('Pixel.CSS3DBlueBoxES3', ['mac'], bug=533690) It would be great ...
4 years, 5 months ago (2016-06-30 02:37:24 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/29468)
4 years, 5 months ago (2016-06-30 03:38:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112603003/1
4 years, 5 months ago (2016-06-30 03:44:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/29481)
4 years, 5 months ago (2016-06-30 04:50:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112603003/1
4 years, 5 months ago (2016-06-30 15:45:27 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 16:21:40 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 16:23:08 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dcc2faa7b3d7a6c57f1c3a9492a132a4f2b9373
Cr-Commit-Position: refs/heads/master@{#403193}

Powered by Google App Engine
This is Rietveld 408576698