third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py - Issue 2112603002: Fix Build.results_url to return the correct results URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

Issue 2112603002: Fix Build.results_url to return the correct results URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

index 2015f4e1958f74af2e1196ee73a01f279947a554..faf0e88585858764461f5d94fd4b6eb95c59ec35 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py

@@ -202,8 +202,7 @@ class Build(object):

return self.build_url(self.builder(), self._number)

def results_url(self):

- results_directory = "r%s (%s)" % (self.revision(), self._number)

- return "%s/%s" % (self._builder.results_url(), urllib.quote(results_directory))

+ return "%s/%s/layout-test-results" % (self._builder.results_url(), self._number)

def results_zip_url(self):

return "%s.zip" % self.results_url()

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py » ('j') | no next file with comments »