Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2112603002: Fix Build.results_url to return the correct results URL. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Build.results_url to return the correct results URL. The base URL for results for a particular build is now: https://storage.googleapis.com/chromium-layout-test-archives/<builder>/<buildnumber>/layout-test-results For some reason, Build.results_url returned something different from that before; I don't think that Build.results_url has been used recently, so it likely got out of date. BUG=474273 Committed: https://crrev.com/b190fc61750420adf481756ccce69157a89d2fe9 Cr-Commit-Position: refs/heads/master@{#402982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
qyearsley
4 years, 5 months ago (2016-06-29 18:00:50 UTC) #2
wkorman
lgtm
4 years, 5 months ago (2016-06-29 18:28:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112603002/1
4 years, 5 months ago (2016-06-29 20:41:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 23:11:03 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 23:11:23 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 23:14:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b190fc61750420adf481756ccce69157a89d2fe9
Cr-Commit-Position: refs/heads/master@{#402982}

Powered by Google App Engine
This is Rietveld 408576698