third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp - Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup, moving csp event to dom debugger Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

index 219e59124841166a7a69df176fac31d0b83b353f..4bff2bcd5106cb3066ba46e64558637cad0c6dee 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

@@ -37,7 +37,6 @@ V8InspectorSessionImpl::V8InspectorSessionImpl(V8DebuggerImpl* debugger, int con

, m_debugger(debugger)

, m_client(client)

, m_customObjectFormatterEnabled(false)

- , m_instrumentationCounter(0)

, m_dispatcher(channel)

, m_state(nullptr)

, m_runtimeAgent(nullptr)

@@ -246,16 +245,6 @@ void V8InspectorSessionImpl::reportAllContexts(V8RuntimeAgentImpl* agent)

agent->reportExecutionContextCreated(idContext.second.get());

}

-void V8InspectorSessionImpl::changeInstrumentationCounter(int delta)

- DCHECK_GE(m_instrumentationCounter + delta, 0);

- if (!m_instrumentationCounter)

- m_client->startInstrumenting();

- m_instrumentationCounter += delta;

- if (!m_instrumentationCounter)

- m_client->stopInstrumenting();

void V8InspectorSessionImpl::dispatchProtocolMessage(const String16& message)

{

m_dispatcher.dispatch(message);