Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: migrated to inspector-protocol test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
index 1142b5e05cfd96908506836fa9e8a359be78e0c5..b4804ae172d6cfbcb866a532726d00613827c7b3 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
@@ -468,6 +468,8 @@ void FrameLoaderClientImpl::dispatchDidStartProvisionalLoad(double triggeringEve
{
if (m_webFrame->client())
m_webFrame->client()->didStartProvisionalLoad(m_webFrame, triggeringEventTime);
+ if (WebDevToolsAgentImpl* devTools = devToolsAgent())
+ devTools->didStartProvisionalLoad(m_webFrame->frame());
}
void FrameLoaderClientImpl::dispatchDidReceiveTitle(const String& title)
@@ -496,9 +498,8 @@ void FrameLoaderClientImpl::dispatchDidCommitLoad(HistoryItem* item, HistoryComm
if (m_webFrame->client())
m_webFrame->client()->didCommitProvisionalLoad(m_webFrame, WebHistoryItem(item), static_cast<WebHistoryCommitType>(commitType));
- WebDevToolsAgentImpl* devToolsAgent = WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())->devToolsAgentImpl();
- if (devToolsAgent)
- devToolsAgent->didCommitLoadForLocalFrame(m_webFrame->frame());
+ if (WebDevToolsAgentImpl* devTools = devToolsAgent())
+ devTools->didCommitLoadForLocalFrame(m_webFrame->frame());
}
void FrameLoaderClientImpl::dispatchDidFailProvisionalLoad(
@@ -1037,4 +1038,9 @@ WebEffectiveConnectionType FrameLoaderClientImpl::getEffectiveConnectionType()
return WebEffectiveConnectionType::TypeUnknown;
}
+WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent()
+{
+ return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())->devToolsAgentImpl();
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/FrameLoaderClientImpl.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698