third_party/WebKit/Source/core/page/Page.cpp - Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: migrated to inspector-protocol test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/testing/NullExecutionContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index ff71fae0c65ade2aa799053f8718ba2b8a3e55f3..e2706cfb914652bbe9c3708c7839d61f0982cad9 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -19,6 +19,7 @@

#include "core/page/Page.h"

+#include "bindings/core/v8/ScriptController.h"

#include "core/css/resolver/ViewportStyleResolver.h"

#include "core/dom/ClientRectList.h"

#include "core/dom/StyleChangeReason.h"

@@ -421,6 +422,20 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

}

break;

+ case SettingsDelegate::DOMWorldsChange:

+ {

+ if (!settings().forceMainWorldInitialization())

+ break;

+ if (!mainFrame() || !mainFrame()->isLocalFrame())

+ break;

+ if (!toLocalFrame(mainFrame())->loader().stateMachine()->committedFirstRealDocumentLoad())

+ break;

+ for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {

+ if (frame->isLocalFrame())

+ toLocalFrame(frame)->script().initializeMainWorld();

+ }

+ break;

}