Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorSession.h

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: migrated to inspector-protocol test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorSession.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorSession.h b/third_party/WebKit/Source/core/inspector/InspectorSession.h
index c4c229a26d5dcf1162bfa3336bda6a770d157461..3f31c00958b0359b91003d74b6ba71fda0c89dd0 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorSession.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorSession.h
@@ -54,11 +54,6 @@ public:
void dispatchProtocolMessage(const String& method, const String& message);
void flushProtocolNotifications() override;
- // Instrumentation methods marked by [V8]
- void scriptExecutionBlockedByCSP(const String& directiveText);
- void didStartProvisionalLoad(LocalFrame*);
- void didClearDocumentOfWindowObject(LocalFrame*);
-
DECLARE_TRACE();
private:
@@ -67,8 +62,8 @@ private:
void sendProtocolNotification(const protocol::String16& message) override;
// V8InspectorSessionClient implementation.
- void startInstrumenting() override;
- void stopInstrumenting() override;
+ void runtimeEnabled() override;
+ void runtimeDisabled() override;
void resumeStartup() override;
bool canExecuteScripts() override;
void profilingStarted() override;
@@ -76,9 +71,6 @@ private:
void consoleEnabled() override;
void consoleCleared() override;
- void forceContextsInAllFrames();
- bool isInstrumenting();
-
Client* m_client;
std::unique_ptr<V8InspectorSession> m_v8Session;
int m_sessionId;

Powered by Google App Engine
This is Rietveld 408576698