[DevTools] Remove [V8] from InspectorInstrumentation.

third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
@@ skipping 259 matching lines @@
     MainThreadDebugger::instance()->didClearContextsForFrame(frame());
 }
 
 void ScriptController::collectIsolatedContexts(Vector<std::pair<ScriptState*, SecurityOrigin*>>& result)
 {
     m_windowProxyManager->collectIsolatedContexts(result);
 }
 
 void ScriptController::updateDocument()
 {
+    bool forceMainWorldInitialization = false;
+    if (canExecuteScripts(NotAboutToExecuteScript) && !frame()->loader().stateMachine()->creatingInitialEmptyDocument()) {
+        Settings* settings = frame()->settings();
+        forceMainWorldInitialization = settings && settings->forceMainWorldInitialization();
+    }
+
     // For an uninitialized main window windowProxy, do not incur the cost of context initialization.
-    if (!m_windowProxyManager->mainWorldProxy()->isGlobalInitialized())
+    if (!forceMainWorldInitialization && !m_windowProxyManager->mainWorldProxy()->isGlobalInitialized())

[haraken, 2016/07/01 02:28:03]

Hmm, it looks a bit nasty to force the main world initialization in
updateDocument(). Don't we have any explicit timing where the inspector can
force the initialization?

[dgozman, 2016/07/06 17:02:20]

Alternatives are LocalDOMWindow::installNewDocument,
DocumentLoader::createWriterFor and DocumentLoader::ensureWriter. I don't think
any of them is better.

As for forcing this from inspector, we try to minimize the side-effects of
instrumentation, and instead rely on direct manipulation through settings. This
makes it clear to anyone working on the specific area that such a functionality
exist. Otherwise, it's easy to miss inspector-only side-effect and break things.
WDYT?

         return;
 
     if (!initializeMainWorld())
         windowProxy(DOMWrapperWorld::mainWorld())->updateDocument();
 }
 
 void ScriptController::namedItemAdded(HTMLDocument* doc, const AtomicString& name)
 {
     windowProxy(DOMWrapperWorld::mainWorld())->namedItemAdded(doc, name);
 }
@@ skipping 148 matching lines @@
         for (size_t i = 0; i < resultArray->Length(); ++i) {
             v8::Local<v8::Value> value;
             if (!resultArray->Get(scriptState->context(), i).ToLocal(&value))
                 return;
             results->append(value);
         }
     }
 }
 
 } // namespace blink