Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2112583002: Revert of [perf] Change google.com to google.ca in top_10_mobile page set. (Closed)

Created:
4 years, 5 months ago by perezju
Modified:
4 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [perf] Change google.com to google.ca in top_10_mobile page set. (patchset #2 id:20001 of https://codereview.chromium.org/2092443002/ ) Reason for revert: Caused artificial memory drop in memory.top_10_mobile benchmark. Sorry if this breaks or flakes other benchmarks. We can re-land (with re-recorded pages) when the dust settles after health plan for this milestone is completed. Original issue's description: > [perf] Change google.com to google.ca in top_10_mobile page set. > > In the top10_mobile page set google.com gets redirected to google.ca. > This sometimes causes problems in telemetry with scrolling. As a short term > fix, replace google.com with google.ca in the page set. > > BUG=chromium:617914 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/d0c95636111161400a576472427de8eeb2330d43 > Cr-Commit-Position: refs/heads/master@{#401863} TBR=petrcermak@chromium.org,nednguyen@google.com,mythria@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:617914 Committed: https://crrev.com/8e45aa437f44a72f971913dd1a3ceb20a6f672ad Cr-Commit-Position: refs/heads/master@{#402865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/perf/page_sets/data/memory_top_10_mobile.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/data/top_10_mobile.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/text_selection_sites.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_10_mobile.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
perezju
Created Revert of [perf] Change google.com to google.ca in top_10_mobile page set.
4 years, 5 months ago (2016-06-29 16:43:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112583002/1
4 years, 5 months ago (2016-06-29 16:46:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 17:56:17 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:56:50 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 17:59:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e45aa437f44a72f971913dd1a3ceb20a6f672ad
Cr-Commit-Position: refs/heads/master@{#402865}

Powered by Google App Engine
This is Rietveld 408576698