Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2112553005: Revert of Redo test after step failure if multiple android devices are connected to lin… (Closed)

Created:
4 years, 5 months ago by Ziqi Xiong
Modified:
4 years, 5 months ago
Reviewers:
RobertoCN
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Redo test after step failure if multiple android devices are connected to lin… (patchset #12 id:220001 of https://codereview.chromium.org/2045043002/ ) Reason for revert: Broke bisect jobs, android_chromium.api.devices() should be changed to android_chromium.api.devices Original issue's description: > Right now, when an android device connected to a bisect linux host goes offline, > we still send bisects to that host, and the bisects fail. > So the device needs to be fixed with extremely urgent priority. > This CL aims to allow multiple devices to be connected to a linux host and if a device failed, > the job would be retried with a device that is still working. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/ad6bb0da9b1a53daae0f47c8d806ffe988c46415 TBR=robertocn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/aa1c49f3de8457745402a466c6f29ac83c2a8268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -49 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 4 chunks +4 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/local_bisect.py View 1 chunk +19 lines, -36 lines 0 comments Download
M scripts/slave/recipe_modules/bisect_tester/api.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/bisect_tester/perf_test.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ziqi Xiong
Created Revert of Redo test after step failure if multiple android devices are connected to ...
4 years, 5 months ago (2016-06-30 17:29:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112553005/1
4 years, 5 months ago (2016-06-30 17:29:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-30 17:29:39 UTC) #5
RobertoCN
lgtm
4 years, 5 months ago (2016-06-30 18:06:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112553005/1
4 years, 5 months ago (2016-06-30 18:06:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/aa1c49f3de8457745402a466c6f29ac83c2a8268
4 years, 5 months ago (2016-06-30 18:10:26 UTC) #10
nednguyen
4 years, 5 months ago (2016-07-07 20:57:11 UTC) #11
Message was sent while issue was closed.
On 2016/06/30 18:10:26, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/tools/build/+/aa1c49f3de8457745402...

Please add test that would catch the problem when you reland.

Powered by Google App Engine
This is Rietveld 408576698