Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issue 2112493002: Roll src/third_party/google_toolbox_for_mac/src/ 03623a95a..e7b41fad2 (2 commits). (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/google_toolbox_for_mac/src/ 03623a95a..e7b41fad2 (2 commits). The main change is that GTMServiceManagement.c now uses sysctl instead of Gestalt() when deploying to 10.8 or 10.9 (and neither when deploying to 10.10), fixing a deprecation warning when bumping the deployment target to 10.8. https://chromium.googlesource.com/external/github.com/google/google-toolbox-for-mac.git/+log/03623a95a6be..e7b41fad2e7f $ git log 03623a95a..e7b41fad2 --date=short --no-merges --format='%ad %ae %s' 2016-06-28 thomasvl GTMServiceManagement.c: Don't use Gestalt() when targeting 10.8+ 2016-06-14 thomasvl Improve the casing macros BUG=622481 Committed: https://crrev.com/0a07ca6fbffcd57f3364e2e183532420ac2a9b12 Cr-Commit-Position: refs/heads/master@{#402810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 5 months ago (2016-06-29 13:25:58 UTC) #4
Robert Sesek
lgtm
4 years, 5 months ago (2016-06-29 14:50:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112493002/1
4 years, 5 months ago (2016-06-29 14:58:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 15:03:16 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 15:03:33 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 15:05:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a07ca6fbffcd57f3364e2e183532420ac2a9b12
Cr-Commit-Position: refs/heads/master@{#402810}

Powered by Google App Engine
This is Rietveld 408576698