[turbofan] Fix non-termination in RedundancyElimination.

[turbofan] Fix non-termination in RedundancyElimination.

A pointer comparison on the effect path states is not sufficient to
guarantee termination; we really need to check the actual nodes to
make sure we terminate properly, similar to what BranchElimination
does.

R=jarin@chromium.org
BUG=v8:5161
Committed: https://crrev.com/89c9fc73bec6a514d98b3d8884c44ffd6bf9c70c
Cr-Commit-Position: refs/heads/master@{#37389}

[Benedikt Meurer, 2016-06-29 11:31:00]

Jaro: PTAL
Michael, Michi: FYI

[Jarin, 2016-06-29 11:32:17]

lgtm

[Benedikt Meurer, 2016-06-29 11:44:56]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-29 11:44:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 11:57:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 11:58:14]

Description was changed from

==========
[turbofan] Fix non-termination in RedundancyElimination.

A pointer comparison on the effect path states is not sufficient to
guarantee termination; we really need to check the actual nodes to
make sure we terminate properly, similar to what BranchElimination
does.

R=jarin@chromium.org
BUG=v8:5161
==========

to

==========
[turbofan] Fix non-termination in RedundancyElimination.

A pointer comparison on the effect path states is not sufficient to
guarantee termination; we really need to check the actual nodes to
make sure we terminate properly, similar to what BranchElimination
does.

R=jarin@chromium.org
BUG=v8:5161

Committed: https://crrev.com/89c9fc73bec6a514d98b3d8884c44ffd6bf9c70c
Cr-Commit-Position: refs/heads/master@{#37389}
==========

[commit-bot: I haz the power, 2016-06-29 11:58:15]

Patchset 1 (id:??) landed as
https://crrev.com/89c9fc73bec6a514d98b3d8884c44ffd6bf9c70c
Cr-Commit-Position: refs/heads/master@{#37389}

[Michael Achenbach, 2016-06-29 12:11:29]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-06-29 12:11:30]

Awesome, thanks!