Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: scripts/slave/recipe_modules/archive/api.py

Issue 2112413002: Allowing zip_build to use a file name given in build_url. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/zip_build.py » ('j') | scripts/slave/zip_build.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/archive/api.py
diff --git a/scripts/slave/recipe_modules/archive/api.py b/scripts/slave/recipe_modules/archive/api.py
index 3a7612bf6076902cac4d52826c34fabd4c0d2dce..b9973365ae7e65996447c16c89a5e702cbf57d48 100644
--- a/scripts/slave/recipe_modules/archive/api.py
+++ b/scripts/slave/recipe_modules/archive/api.py
@@ -106,9 +106,11 @@ class ArchiveApi(recipe_api.RecipeApi):
'--staging-dir', self.m.path['cache'].join('chrome_staging'),
'--src-dir', src_dir,
]
- if build_url or 'build_archive_url' in self.m.properties:
- args.extend(['--build-url',
- build_url or self.m.properties['build_archive_url']])
+ if 'build_archive_url' in self.m.properties: # pragma: no cover
martiniss 2016/07/06 21:28:47 Can you add a test to the example.py in this recip
RobertoCN 2016/07/06 22:06:49 Done.
+ args.extend(['--override-archive-name', '--build-url',
+ self.m.properties['build_archive_url']])
+ elif build_url:
+ args.extend(['--build-url', build_url])
if build_revision:
args.extend(['--build_revision', build_revision])
if cros_board:
« no previous file with comments | « no previous file | scripts/slave/zip_build.py » ('j') | scripts/slave/zip_build.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698