Allowing zip_build to use a file name given in build_url.

Allowing zip_build to use a file name given in build_url.

In bisect and tryjobs we want to control from the recipe what the
filename of the uploaded zip will be. With this change we piggyback on
the build_url parameter to optionally pass such filename, and add a flag
to determine whether to interpret this url as containing such filname.

R=dtu,aiolos

Committed: https://chromium.googlesource.com/chromium/tools/build/+/b7d21298321fe86d2d3a42430f0d474362929ce6

[dtu, 2016-07-06 21:12:22]

lgtm to fix the bisect bots. You still need an OWNERS lgtm.

A better solution overall could be to relinquish the ability to specify the URL
from bisect/try, as the logic in bisect is very brittle anyway. [1] Add the
ability to specify a commit hash suffix to zip_build.py and rely on that to
determine the URL.


[1]
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...

[RobertoCN, 2016-07-06 21:22:33]

Description was changed from

==========
Allowing zip_build to use a file name given in build_url.

In bisect and tryjobs we want to control from the recipe what the
filename of the uploaded zip will be. With this change we piggyback on
the build_url parameter to optionally pass such filename, and add a flag
to determine whether to interpret this url as containing such filname.

R=dtu,aiolos
==========

to

==========
Allowing zip_build to use a file name given in build_url.

In bisect and tryjobs we want to control from the recipe what the
filename of the uploaded zip will be. With this change we piggyback on
the build_url parameter to optionally pass such filename, and add a flag
to determine whether to interpret this url as containing such filname.

R=dtu,aiolos
==========

[RobertoCN, 2016-07-06 21:22:33]

robertocn@chromium.org changed reviewers:
+ hinoka@chromium.org, martiniss@chromium.org

[RobertoCN, 2016-07-06 21:22:51]

+infra for owners check.

[martiniss, 2016-07-06 21:28:47]

lgtm with some comments

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/archive/api.py (right):

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/archive/api.py:109: if 'build_archive_url' in
self.m.properties:  # pragma: no cover
Can you add a test to the example.py in this recipe module

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/zip_build.py
File scripts/slave/zip_build.py (right):

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/zip_build.py#...
scripts/slave/zip_build.py:443:
option_parser.add_option('--override-archive-name', action='store_true',
Maybe name this '--use-build-url-name' instead? Override makes me think I can
specify the name, but I actually can't.

[RobertoCN, 2016-07-06 22:06:50]

Addressed both comments.

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/archive/api.py (right):

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/archive/api.py:109: if 'build_archive_url' in
self.m.properties:  # pragma: no cover
On 2016/07/06 21:28:47, martiniss wrote:
> Can you add a test to the example.py in this recipe module 

Done.

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/zip_build.py
File scripts/slave/zip_build.py (right):

https://codereview.chromium.org/2112413002/diff/1/scripts/slave/zip_build.py#...
scripts/slave/zip_build.py:443:
option_parser.add_option('--override-archive-name', action='store_true',
On 2016/07/06 21:28:47, martiniss wrote:
> Maybe name this '--use-build-url-name' instead? Override makes me think I can
> specify the name, but I actually can't. 

Done.

[RobertoCN, 2016-07-06 22:16:30]

The CQ bit was checked by robertocn@chromium.org

[RobertoCN, 2016-07-06 22:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org,
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2112413002/#ps40001
(title: "Untouching blank line.")

[commit-bot: I haz the power, 2016-07-06 22:16:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 22:20:56]

Description was changed from

==========
Allowing zip_build to use a file name given in build_url.

In bisect and tryjobs we want to control from the recipe what the
filename of the uploaded zip will be. With this change we piggyback on
the build_url parameter to optionally pass such filename, and add a flag
to determine whether to interpret this url as containing such filname.

R=dtu,aiolos
==========

to

==========
Allowing zip_build to use a file name given in build_url.

In bisect and tryjobs we want to control from the recipe what the
filename of the uploaded zip will be. With this change we piggyback on
the build_url parameter to optionally pass such filename, and add a flag
to determine whether to interpret this url as containing such filname.

R=dtu,aiolos

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b7d21298321fe86d2d3a...
==========

[commit-bot: I haz the power, 2016-07-06 22:20:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/b7d21298321fe86d2d3a...