Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: build/args/blimp_engine.gn

Issue 2112383003: Disable udev from Engine builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/args/blimp_engine.gn
diff --git a/build/args/blimp_engine.gn b/build/args/blimp_engine.gn
index 24f5c17ea3c9f3df08d9defaa089c71d93a1f038..5bb82ff5ef5105226899ccfef2235448ec795bff 100644
--- a/build/args/blimp_engine.gn
+++ b/build/args/blimp_engine.gn
@@ -23,3 +23,7 @@ use_alsa = false
use_pulseaudio = false
use_cups = false
use_glib = false
+
+# udev is not supported on targetted platform and also not something that will
Wez 2016/07/05 19:58:19 typo: targeted
Sriram 2016/07/06 20:09:08 Done.
+# be used by Blimp Engine.
+use_udev = false
Dirk Pranke 2016/07/01 22:10:00 Does the comment really say anything different tha
Wez 2016/07/05 19:58:19 Agreed - perhaps move this into the use_* block ab
Sriram 2016/07/06 20:09:08 Line 21 is docker container specific and here are
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698