Disable udev from Engine builds

Disable udev from Engine builds

udev support in Linux is used to get plug & play notification when an USB device
is plugged in. This is something that is unlikely to be used in Blimp Engine. So
disabling the code from Blimp Engine build.

BUG=625277
Committed: https://crrev.com/a2c19e55cf5e0e87f2b99232182c1be0a94be9f1
Cr-Commit-Position: refs/heads/master@{#403983}

[Sriram, 2016-07-01 22:07:03]

sriramsr@chromium.org changed reviewers:
+ dpranke@chromium.org, wez@chromium.org

[Dirk Pranke, 2016-07-01 22:10:00]

lgtm w/ nit.

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn
File build/args/blimp_engine.gn (right):

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn#...
build/args/blimp_engine.gn:29: use_udev = false
Does the comment really say anything different than what the comment on line 21
says?

[Wez, 2016-07-05 19:58:19]

lgtm

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn
File build/args/blimp_engine.gn (right):

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn#...
build/args/blimp_engine.gn:27: # udev is not supported on targetted platform and
also not something that will
typo: targeted

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn#...
build/args/blimp_engine.gn:29: use_udev = false
On 2016/07/01 22:10:00, Dirk Pranke wrote:
> Does the comment really say anything different than what the comment on line
21
> says?

Agreed - perhaps move this into the use_* block above.

[Sriram, 2016-07-06 20:09:08]

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn
File build/args/blimp_engine.gn (right):

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn#...
build/args/blimp_engine.gn:27: # udev is not supported on targetted platform and
also not something that will
On 2016/07/05 19:58:19, Wez wrote:
> typo: targeted

Done.

https://codereview.chromium.org/2112383003/diff/1/build/args/blimp_engine.gn#...
build/args/blimp_engine.gn:29: use_udev = false
On 2016/07/01 22:10:00, Dirk Pranke wrote:
> Does the comment really say anything different than what the comment on line
21
> says?

Line 21 is docker container specific and here are disabling udev even though it
is available. I would like to keep it along with stuff we disable even though it
might work in docker container.

[Sriram, 2016-07-06 20:09:28]

The CQ bit was checked by sriramsr@chromium.org

[Sriram, 2016-07-06 20:09:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/2112383003/#ps20001
(title: "Updated based on CR comment")

[commit-bot: I haz the power, 2016-07-06 20:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:41:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-06 23:41:59]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 23:44:24]

Description was changed from

==========
Disable udev from Engine builds

udev support in Linux is used to get plug & play notification when an USB device
is plugged in. This is something that is unlikely to be used in Blimp Engine. So
disabling the code from Blimp Engine build.

BUG=625277
==========

to

==========
Disable udev from Engine builds

udev support in Linux is used to get plug & play notification when an USB device
is plugged in. This is something that is unlikely to be used in Blimp Engine. So
disabling the code from Blimp Engine build.

BUG=625277

Committed: https://crrev.com/a2c19e55cf5e0e87f2b99232182c1be0a94be9f1
Cr-Commit-Position: refs/heads/master@{#403983}
==========

[commit-bot: I haz the power, 2016-07-06 23:44:25]

Patchset 2 (id:??) landed as
https://crrev.com/a2c19e55cf5e0e87f2b99232182c1be0a94be9f1
Cr-Commit-Position: refs/heads/master@{#403983}