Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2112383002: [CacheStorage] Initialize the cache backend immediately upon opening (Closed)

Created:
4 years, 5 months ago by jkarlin
Modified:
4 years, 5 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Initialize the cache backend immediately upon opening instead of lazily. Caches are used immediately after opening, we shouldn't lazily init them. This CL: 1) Immediately initializes its backend upon creation 2) Changes the init method to use a pending closure, like the rest of the class. BUG=629544 Committed: https://crrev.com/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a Cr-Commit-Position: refs/heads/master@{#406430}

Patch Set 1 : format #

Patch Set 2 : Clean up #

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -48 lines) Patch
M content/browser/cache_storage/cache_storage_cache.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 1 2 13 chunks +30 lines, -36 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 1 3 chunks +3 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jkarlin
jsbell@ PTAL, thanks!
4 years, 5 months ago (2016-07-19 17:52:27 UTC) #6
jsbell
lgtm
4 years, 5 months ago (2016-07-19 23:03:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112383002/60001
4 years, 5 months ago (2016-07-20 00:40:39 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-20 00:46:08 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 00:46:20 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 00:47:53 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a
Cr-Commit-Position: refs/heads/master@{#406430}

Powered by Google App Engine
This is Rietveld 408576698