CSS Transforms: Implement perspective

CSS Transforms: Implement perspective

Implements perspective as defined in CSS Transforms[1]. Behavior is
similar to -webkit-perspective, but numbers without units are not
valid. In both variants we accept zero although Gecko and spec
require a positive value.

The animation system is modified to avoid running animations and
transitions on both the prefixed and unprefixed variants at the same
time. Internally, animations are mapped to the unprefixed variant.
As animations operate directly on the RenderStyle storage the result
of specifying an animation/transition on either property is the same.

Transitions now track the specified transition-property such that
the end event may reference it. (eg. transition:
-webkit-perspective; will fire an end  event with
propertyName == '-webkit-perspective'). As transitions operate on
changes to values within a RenderStyle, 'transition: all;' only
ever starts transitions on the unprefixed variants.

Note, this property is guarded by the CSSTransformsUnprefixed runtime
feature (enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170326

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170517

[eseidel, 2014-03-27 23:13:21]

lgtm

https://codereview.chromium.org/211233003/diff/30001/Source/core/animation/cs...
File Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/211233003/diff/30001/Source/core/animation/cs...
Source/core/animation/css/CSSAnimations.cpp:77: switch (property) {
Why the switch?  I guess your'e going to add more?

[commit-bot: I haz the power, 2014-03-27 23:13:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211233003/30001

[commit-bot: I haz the power, 2014-03-27 23:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 23:13:35]

Failed to apply patch for Source/core/css/CSSComputedStyleDeclaration.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSComputedStyleDeclaration.cpp
  Hunk #1 succeeded at 294 (offset -3 lines).
  Hunk #2 succeeded at 2501 (offset -8 lines).
  Hunk #3 FAILED at 2775.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/css/CSSComputedStyleDeclaration.cpp.rej

Patch:       Source/core/css/CSSComputedStyleDeclaration.cpp
Index: Source/core/css/CSSComputedStyleDeclaration.cpp
diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp
b/Source/core/css/CSSComputedStyleDeclaration.cpp
index
5dba091f6fc59a1c3d6d34e7506affd14370809c..c2a2cb4eb7ee7afc251419956a38781616113c62
100644
--- a/Source/core/css/CSSComputedStyleDeclaration.cpp
+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp
@@ -297,6 +297,7 @@ static const CSSPropertyID staticComputableProperties[] = {
     CSSPropertyWebkitMaskRepeat,
     CSSPropertyWebkitMaskSize,
     CSSPropertyOrder,
+    CSSPropertyPerspective,
     CSSPropertyWebkitPerspective,
     CSSPropertyWebkitPerspectiveOrigin,
     CSSPropertyWebkitPrintColorAdjust,
@@ -2508,6 +2509,7 @@ PassRefPtrWillBeRawPtr<CSSValue>
CSSComputedStyleDeclaration::getPropertyCSSValu
         case CSSPropertyWebkitMarginTopCollapse:
         case CSSPropertyWebkitMarginBeforeCollapse:
             return cssValuePool().createValue(style->marginBeforeCollapse());
+        case CSSPropertyPerspective:
         case CSSPropertyWebkitPerspective:
             if (!style->hasPerspective())
                 return cssValuePool().createIdentifierValue(CSSValueNone);
@@ -2773,7 +2775,6 @@ PassRefPtrWillBeRawPtr<CSSValue>
CSSComputedStyleDeclaration::getPropertyCSSValu
             break;
 
         // FIXME: crbug.com/154772 Unimplemented css-transforms properties
-        case CSSPropertyPerspective:
         case CSSPropertyPerspectiveOrigin:
         case CSSPropertyTransform:
         case CSSPropertyTransformOrigin:

[dstockwell, 2014-03-27 23:21:08]

https://codereview.chromium.org/211233003/diff/30001/Source/core/animation/cs...
File Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/211233003/diff/30001/Source/core/animation/cs...
Source/core/animation/css/CSSAnimations.cpp:77: switch (property) {
On 2014/03/27 23:13:22, eseidel wrote:
> Why the switch?  I guess your'e going to add more?

Yes.

[dstockwell, 2014-03-28 12:24:47]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-03-28 12:24:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211233003/90001

[commit-bot: I haz the power, 2014-03-28 12:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 12:25:11]

Failed to apply patch for Source/core/animation/css/CSSAnimations.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/animation/css/CSSAnimations.cpp
  Hunk #1 succeeded at 72 with fuzz 2.
  Hunk #2 FAILED at 97.
  Hunk #3 succeeded at 109 (offset -1 lines).
  Hunk #4 succeeded at 125 (offset -1 lines).
  Hunk #5 succeeded at 409 (offset -86 lines).
  Hunk #6 succeeded at 492 (offset -86 lines).
  Hunk #7 succeeded at 535 (offset -86 lines).
  Hunk #8 succeeded at 780 with fuzz 1 (offset -91 lines).
  1 out of 8 hunks FAILED -- saving rejects to file
Source/core/animation/css/CSSAnimations.cpp.rej

Patch:       Source/core/animation/css/CSSAnimations.cpp
Index: Source/core/animation/css/CSSAnimations.cpp
diff --git a/Source/core/animation/css/CSSAnimations.cpp
b/Source/core/animation/css/CSSAnimations.cpp
index
7c1dbcc1d3f59b59f1f5f6b1d4322ea1240fe2c2..ae3fe9148ef1b354564e8c89ae7c8d503378cd5b
100644
--- a/Source/core/animation/css/CSSAnimations.cpp
+++ b/Source/core/animation/css/CSSAnimations.cpp
@@ -72,6 +72,17 @@ bool isLaterPhase(TimedItem::Phase target, TimedItem::Phase
reference)
     return target > reference;
 }
 
+CSSPropertyID propertyForAnimation(CSSPropertyID property)
+{
+    switch (property) {
+    case CSSPropertyWebkitPerspective:
+        return CSSPropertyPerspective;
+    default:
+        break;
+    }
+    return property;
+}
+
 static void resolveKeyframes(StyleResolver* resolver, Element* element, const
Element& parentElement, const RenderStyle& style, RenderStyle* parentStyle,
const AtomicString& name, TimingFunction* defaultTimingFunction,
     WillBeHeapVector<KeyframeEffectModel::KeyframeVector>& resolvedKeyframes)
 {
@@ -86,7 +97,7 @@ static void resolveKeyframes(StyleResolver* resolver, Element*
element, const El
         return;
 
     // Construct and populate the style for each keyframe
-    PropertySet specifiedProperties;
+    PropertySet specifiedPropertiesForUseCounter;
     KeyframeEffectModel::KeyframeVector keyframes;
     for (size_t i = 0; i < styleKeyframes.size(); ++i) {
         const StyleKeyframe* styleKeyframe = styleKeyframes[i].get();
@@ -99,12 +110,13 @@ static void resolveKeyframes(StyleResolver* resolver,
Element* element, const El
         keyframe->setEasing(defaultTimingFunction);
         const StylePropertySet& properties = styleKeyframe->properties();
         for (unsigned j = 0; j < properties.propertyCount(); j++) {
-            CSSPropertyID property = properties.propertyAt(j).id();
-            specifiedProperties.add(property);
-            if (property == CSSPropertyWebkitAnimationTimingFunction ||
property == CSSPropertyAnimationTimingFunction)
+           
specifiedPropertiesForUseCounter.add(properties.propertyAt(j).id());
+            CSSPropertyID property =
propertyForAnimation(properties.propertyAt(j).id());
+            if (property == CSSPropertyWebkitAnimationTimingFunction ||
property == CSSPropertyAnimationTimingFunction) {
                
keyframe->setEasing(KeyframeValue::timingFunction(*keyframeStyle));
-            else if (CSSAnimations::isAnimatableProperty(property))
+            } else if (CSSAnimations::isAnimatableProperty(property)) {
                 keyframe->setPropertyValue(property,
CSSAnimatableValueFactory::create(property, *keyframeStyle).get());
+            }
         }
         keyframes.append(keyframe);
         // The last keyframe specified at a given offset is used.
@@ -114,7 +126,7 @@ static void resolveKeyframes(StyleResolver* resolver,
Element* element, const El
     }
     ASSERT(!keyframes.isEmpty());
 
-    for (PropertySet::const_iterator iter = specifiedProperties.begin(); iter
!= specifiedProperties.end(); ++iter) {
+    for (PropertySet::const_iterator iter =
specifiedPropertiesForUseCounter.begin(); iter !=
specifiedPropertiesForUseCounter.end(); ++iter) {
         const CSSPropertyID property = *iter;
         ASSERT(property != CSSPropertyInvalid);
        
blink::Platform::current()->histogramSparse("WebCore.Animation.CSSProperties",
UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(property));
@@ -483,7 +495,7 @@ void CSSAnimations::maybeApplyPendingUpdate(Element*
element)
 
         CSSPropertyID id = newTransition.id;
         InertAnimation* inertAnimation = newTransition.animation.get();
-        OwnPtr<TransitionEventDelegate> eventDelegate = adoptPtr(new
TransitionEventDelegate(element, id));
+        OwnPtr<TransitionEventDelegate> eventDelegate = adoptPtr(new
TransitionEventDelegate(element, newTransition.eventId));
 
         RefPtrWillBeRawPtr<AnimationEffect> effect = inertAnimation->effect();
 
@@ -566,7 +578,8 @@ void
CSSAnimations::calculateTransitionUpdateForProperty(CSSPropertyID id, const
 
     RefPtrWillBeRawPtr<KeyframeEffectModel> effect =
KeyframeEffectModel::create(keyframes);
 
-    update->startTransition(id, from.get(), to.get(),
InertAnimation::create(effect, timing, isPaused));
+    CSSPropertyID eventId = anim->animationMode() ==
CSSAnimationData::AnimateAll ? id : anim->property();
+    update->startTransition(id, eventId, from.get(), to.get(),
InertAnimation::create(effect, timing, isPaused));
     ASSERT(!element->activeAnimations() ||
!element->activeAnimations()->isAnimationStyleChange());
 }
 
@@ -608,6 +621,7 @@ void
CSSAnimations::calculateTransitionUpdate(CSSAnimationUpdate* update, const
                 CSSPropertyID id = propertyList.length() ?
propertyList.properties()[j] : anim->property();
 
                 if (!animateAll) {
+                    id = propertyForAnimation(id);
                     if (CSSAnimations::isAnimatableProperty(id))
                         listedProperties.set(id);
                     else
@@ -857,7 +871,7 @@ bool CSSAnimations::isAnimatableProperty(CSSPropertyID
property)
     case CSSPropertyWebkitMaskPositionX:
     case CSSPropertyWebkitMaskPositionY:
     case CSSPropertyWebkitMaskSize:
-    case CSSPropertyWebkitPerspective:
+    case CSSPropertyPerspective:
     case CSSPropertyWebkitPerspectiveOriginX:
     case CSSPropertyWebkitPerspectiveOriginY:
     case CSSPropertyShapeInside:

[dstockwell, 2014-03-28 12:39:24]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-03-28 12:39:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211233003/110001

[commit-bot: I haz the power, 2014-03-28 13:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 13:17:06]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[dstockwell, 2014-03-28 13:21:54]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-03-28 13:22:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211233003/110001

[commit-bot: I haz the power, 2014-03-28 13:53:29]

Change committed as 170326

[dstockwell, 2014-04-01 05:18:26]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-04-01 05:18:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/211233003/130001

[commit-bot: I haz the power, 2014-04-01 06:26:58]

Change committed as 170517