Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2112213002: Clean up CFX_MacFontInfo and surrounding code. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Clean up CFX_MacFontInfo and surrounding code. Committed: https://pdfium.googlesource.com/pdfium/+/08e707273ef50c3a2365ff976e96e761800016d3

Patch Set 1 : compile #

Total comments: 2

Patch Set 2 : nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -67 lines) Patch
M core/fxge/apple/apple_int.h View 2 chunks +1 line, -40 lines 0 comments Download
M core/fxge/apple/fx_mac_imp.cpp View 1 5 chunks +30 lines, -27 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
Lei Zhang
4 years, 5 months ago (2016-07-01 15:10:44 UTC) #5
Wei Li
lgtm https://codereview.chromium.org/2112213002/diff/60001/core/fxge/apple/fx_mac_imp.cpp File core/fxge/apple/fx_mac_imp.cpp (right): https://codereview.chromium.org/2112213002/diff/60001/core/fxge/apple/fx_mac_imp.cpp#newcode69 core/fxge/apple/fx_mac_imp.cpp:69: found = true; |found| is not needed, you ...
4 years, 5 months ago (2016-07-01 17:00:14 UTC) #6
Lei Zhang
https://codereview.chromium.org/2112213002/diff/60001/core/fxge/apple/fx_mac_imp.cpp File core/fxge/apple/fx_mac_imp.cpp (right): https://codereview.chromium.org/2112213002/diff/60001/core/fxge/apple/fx_mac_imp.cpp#newcode69 core/fxge/apple/fx_mac_imp.cpp:69: found = true; On 2016/07/01 17:00:14, Wei Li wrote: ...
4 years, 5 months ago (2016-07-01 17:13:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112213002/80001
4 years, 5 months ago (2016-07-01 17:17:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:80001) as https://pdfium.googlesource.com/pdfium/+/08e707273ef50c3a2365ff976e96e761800016d3
4 years, 5 months ago (2016-07-01 17:24:55 UTC) #12
Lei Zhang
4 years, 5 months ago (2016-07-01 18:50:30 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/2112213002/diff/80001/core/fxge/apple/fx_mac_...
File core/fxge/apple/fx_mac_imp.cpp (right):

https://codereview.chromium.org/2112213002/diff/80001/core/fxge/apple/fx_mac_...
core/fxge/apple/fx_mac_imp.cpp:70: break;
Whoops, forgot to remove the break. No worries. I have another CL coming up to
fix a bug, so I will remove it there.

Powered by Google App Engine
This is Rietveld 408576698