Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2112193002: X87: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland [heap] Avoid the use of cells to point from code to new-space objects. port 5e058540192eaf95e8d1c2c3d0920219491cde15 (r37325) original commit message: The reason for reverting is: This breaks gc-stress bot: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot Abortion of compaction could cause duplicate entries in the typed-old-to-new remembered set. These duplicates could cause a DCHECK to trigger which checks that slots recorded in the remembered set neve Original issue's description: Cells were needed originally because there was no typed remembered set to record direct pointers from code space to new space. A previous CL (https://codereview.chromium.org/2003553002/) already introduced the remembered set, this CL uses it. This CL * stores direct pointers in code objects, even if the target is in new space, * records the slot of the pointer in typed-old-to-new remembered set, * adds a list which stores weak code-to-new-space references, * adds a test to test-heap.cc for weak code-to-new-space references, * removes prints in tail-call-megatest.js BUG= Committed: https://crrev.com/35f3143c6a8040de92e38cadd5685ee2d9d3296b Cr-Commit-Position: refs/heads/master@{#37466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -29 lines) Patch
M src/x87/assembler-x87-inl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +3 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-01 02:48:22 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-01 03:29:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112193002/1
4 years, 5 months ago (2016-07-01 03:40:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 04:29:21 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 04:32:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35f3143c6a8040de92e38cadd5685ee2d9d3296b
Cr-Commit-Position: refs/heads/master@{#37466}

Powered by Google App Engine
This is Rietveld 408576698