Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2112183002: [Offline Pages] Refactoring deletion of pages with same urls. (Closed)

Created:
4 years, 5 months ago by romax
Modified:
4 years, 5 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Refactoring deletion of pages with same urls. Simple refactoring to make InformSavePageDone() doesn't do extra work. BUG=624043 Committed: https://crrev.com/f258f19fe9c59c5f6445d069637c95a09efc926c Cr-Commit-Position: refs/heads/master@{#404298}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments. #

Total comments: 1

Patch Set 3 : comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M components/offline_pages/offline_page_model_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 2 2 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
romax
PTAL, simple change. Thanks!
4 years, 5 months ago (2016-07-01 01:58:08 UTC) #2
fgorski
Mostly look good. 2 comments. https://codereview.chromium.org/2112183002/diff/1/components/offline_pages/offline_page_model_impl.cc File components/offline_pages/offline_page_model_impl.cc (right): https://codereview.chromium.org/2112183002/diff/1/components/offline_pages/offline_page_model_impl.cc#newcode743 components/offline_pages/offline_page_model_impl.cc:743: DeleteExistingPageWithSameURL(result, offline_page); Did you ...
4 years, 5 months ago (2016-07-01 17:43:22 UTC) #3
romax
addressed comments. PTAL https://codereview.chromium.org/2112183002/diff/1/components/offline_pages/offline_page_model_impl.cc File components/offline_pages/offline_page_model_impl.cc (right): https://codereview.chromium.org/2112183002/diff/1/components/offline_pages/offline_page_model_impl.cc#newcode743 components/offline_pages/offline_page_model_impl.cc:743: DeleteExistingPageWithSameURL(result, offline_page); On 2016/07/01 17:43:22, fgorski ...
4 years, 5 months ago (2016-07-06 19:44:50 UTC) #4
fgorski
lgtm https://codereview.chromium.org/2112183002/diff/20001/components/offline_pages/offline_page_model_impl.cc File components/offline_pages/offline_page_model_impl.cc (right): https://codereview.chromium.org/2112183002/diff/20001/components/offline_pages/offline_page_model_impl.cc#newcode825 components/offline_pages/offline_page_model_impl.cc:825: if (pages_allowed != kUnlimitedPages) { nit: if (pages_allowed ...
4 years, 5 months ago (2016-07-07 17:03:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112183002/40001
4 years, 5 months ago (2016-07-07 21:41:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 23:43:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112183002/40001
4 years, 5 months ago (2016-07-08 01:10:12 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 01:15:57 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 01:16:06 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:20:30 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f258f19fe9c59c5f6445d069637c95a09efc926c
Cr-Commit-Position: refs/heads/master@{#404298}

Powered by Google App Engine
This is Rietveld 408576698