Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: test/mjsunit/es6/block-eval-var-over-let.js

Issue 2112163002: Block-scoped functions in evals are now only conditionally hoisted out. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/block-eval-var-over-let.js
diff --git a/test/mjsunit/es6/block-eval-var-over-let.js b/test/mjsunit/es6/block-eval-var-over-let.js
index b68dbdd12ddafb138f9d8aebda1757154f2ac4ef..3dc8c47c209d32227bc5322b6279004f5eb308fb 100644
--- a/test/mjsunit/es6/block-eval-var-over-let.js
+++ b/test/mjsunit/es6/block-eval-var-over-let.js
@@ -124,8 +124,6 @@ try {
}
assertTrue(caught);
-// TODO(littledan): Hoisting x out of the block should be
-// prevented in this case BUG(v8:4479)
caught = false
try {
(function() {
@@ -137,5 +135,4 @@ try {
} catch (e) {
caught = true;
}
-// TODO(littledan): switch to assertTrue when bug is fixed
-assertTrue(caught);
+assertFalse(caught);

Powered by Google App Engine
This is Rietveld 408576698