Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2112123002: ChromeOS: strings for the network screen (Closed)

Created:
4 years, 5 months ago by Alexander Alekseev
Modified:
4 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: strings for the network screen This CL includes strings for the network screen. BUG=604119 TEST=NONE TBR=stevenjb@chromium.org Committed: https://crrev.com/6a675c851fc18a838970d8733786bd5421caebbc Cr-Commit-Position: refs/heads/master@{#403367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +15 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112123002/1
4 years, 5 months ago (2016-06-30 23:07:49 UTC) #2
Alexander Alekseev
4 years, 5 months ago (2016-06-30 23:08:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 23:49:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112123002/1
4 years, 5 months ago (2016-07-01 00:13:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 00:27:19 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 00:27:27 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a675c851fc18a838970d8733786bd5421caebbc Cr-Commit-Position: refs/heads/master@{#403367}
4 years, 5 months ago (2016-07-01 00:29:27 UTC) #14
stevenjb
Any reason we cant include this with the CL that uses these strings?
4 years, 5 months ago (2016-07-01 00:34:20 UTC) #15
stevenjb
4 years, 5 months ago (2016-07-01 00:34:52 UTC) #16
Message was sent while issue was closed.
On 2016/07/01 00:34:20, stevenjb wrote:
> Any reason we cant include this with the CL that uses these strings?

Too late I guess, nevermind.

Powered by Google App Engine
This is Rietveld 408576698