Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Unified Diff: runtime/vm/pages.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/pages.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.cc
diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc
index e5d1e65f0839aae645ed145b6557025dc43b69c5..6796cc729dff1638bbfbdf45bfc0f5685275db78 100644
--- a/runtime/vm/pages.cc
+++ b/runtime/vm/pages.cc
@@ -12,7 +12,6 @@
#include "vm/object.h"
#include "vm/os_thread.h"
#include "vm/safepoint.h"
-#include "vm/verified_memory.h"
#include "vm/virtual_memory.h"
namespace dart {
@@ -57,7 +56,7 @@ HeapPage* HeapPage::Initialize(VirtualMemory* memory, PageType type) {
HeapPage* HeapPage::Allocate(intptr_t size_in_words, PageType type) {
VirtualMemory* memory =
- VerifiedMemory::Reserve(size_in_words << kWordSizeLog2);
+ VirtualMemory::Reserve(size_in_words << kWordSizeLog2);
if (memory == NULL) {
return NULL;
}
@@ -1055,23 +1054,6 @@ uword PageSpace::TryAllocatePromoLocked(intptr_t size,
}
-uword PageSpace::TryAllocateSmiInitializedLocked(intptr_t size,
- GrowthPolicy growth_policy) {
- uword result = TryAllocateDataBumpLocked(size, growth_policy);
- if (collections() != 0) {
- FATAL1("%" Pd " GCs before TryAllocateSmiInitializedLocked", collections());
- }
-#if defined(DEBUG)
- RawObject** begin = reinterpret_cast<RawObject**>(result);
- RawObject** end = reinterpret_cast<RawObject**>(result + size);
- for (RawObject** current = begin; current < end; ++current) {
- ASSERT(!(*current)->IsHeapObject());
- }
-#endif
- return result;
-}
-
-
void PageSpace::SetupExternalPage(void* pointer,
uword size,
bool is_executable) {
« no previous file with comments | « runtime/vm/pages.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698